bpo-41867: Include options for timespec in docstrings of isoformat methods by cool-RR · Pull Request #22418 · python/cpython

cool-RR · 2020-09-26T16:48:01Z

https://bugs.python.org/issue41867

taleinat · 2020-10-02T18:16:23Z

Hi Ram, thanks for this, it's a nice addition!

What about the doc-strings for the C implementation? (e.g. here)

taleinat · 2020-10-02T18:21:41Z

What about the doc-strings for the C implementation? (e.g. here)

It seems that the C implementation for datetime.iso_format() already has something very similar in its doc-string, while time.iso_format() doesn't.

Let's make these all consistent.

cool-RR · 2020-10-03T09:34:46Z

Done.

taleinat

Almost good to go, just a couple of small comments.

Misc/NEWS.d/next/Library/2020-09-26-19-45-06.bpo-41867.hcueGL.rst

Lib/datetime.py

bedevere-bot · 2020-10-03T09:43:30Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

cool-RR · 2020-10-03T09:46:36Z

I have made the requested changes; please review again

bedevere-bot · 2020-10-03T09:46:39Z

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

taleinat

Wow, @cool-RR, that was quick!

One more thing...

Modules/_datetimemodule.c

bedevere-bot · 2020-10-03T09:51:04Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

cool-RR · 2020-10-03T09:53:02Z

I have made the requested changes; please review again

bedevere-bot · 2020-10-03T09:53:05Z

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

cool-RR · 2020-10-03T09:59:51Z

I have made the requested changes; please review again

bedevere-bot · 2020-10-03T09:59:54Z

Thanks for making the requested changes!

@taleinat: please review the changes made to this pull request.

taleinat

LGTM

miss-islington · 2020-10-03T10:43:50Z

Thanks @cool-RR for the PR, and @taleinat for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

…ds (pythonGH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

bedevere-bot · 2020-10-03T10:44:02Z

GH-22518 is a backport of this pull request to the 3.9 branch.

…ds (pythonGH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

bedevere-bot · 2020-10-03T10:44:11Z

GH-22519 is a backport of this pull request to the 3.8 branch.

…ds (GH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

… methods (GH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

… methods (pythonGH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

…ds (pythonGH-22418)

cool-RR requested review from abalkin and pganssle as code owners September 26, 2020 16:48

the-knights-who-say-ni added the CLA signed label Sep 26, 2020

bedevere-bot added the awaiting review label Sep 26, 2020

taleinat added skip news docs Documentation in the Doc dir labels Oct 2, 2020

cool-RR force-pushed the 2020-09-26-isoformat branch 2 times, most recently from e2e0ba5 to 8a7abe4 Compare October 3, 2020 09:34

taleinat requested changes Oct 3, 2020

View reviewed changes

Misc/NEWS.d/next/Library/2020-09-26-19-45-06.bpo-41867.hcueGL.rst Outdated Show resolved Hide resolved

Lib/datetime.py Outdated Show resolved Hide resolved

bedevere-bot removed the awaiting review label Oct 3, 2020

bedevere-bot added the awaiting changes label Oct 3, 2020

cool-RR force-pushed the 2020-09-26-isoformat branch from 8a7abe4 to 70dd716 Compare October 3, 2020 09:46

bedevere-bot added awaiting change review and removed awaiting changes labels Oct 3, 2020

bedevere-bot requested a review from taleinat October 3, 2020 09:46

taleinat requested changes Oct 3, 2020

View reviewed changes

Modules/_datetimemodule.c Outdated Show resolved Hide resolved

bedevere-bot removed the awaiting change review label Oct 3, 2020

bedevere-bot added the awaiting changes label Oct 3, 2020

cool-RR force-pushed the 2020-09-26-isoformat branch from 70dd716 to dbfeb83 Compare October 3, 2020 09:53

bedevere-bot added awaiting change review and removed awaiting changes labels Oct 3, 2020

bpo-41867: Show options for timespec in isoformat docstrings

2cf017b

cool-RR force-pushed the 2020-09-26-isoformat branch from dbfeb83 to 2cf017b Compare October 3, 2020 09:58

bedevere-bot added awaiting change review and removed awaiting changes labels Oct 3, 2020

bedevere-bot requested a review from taleinat October 3, 2020 09:59

more doc-string formatting tweaks in C code

2a51cb1

taleinat approved these changes Oct 3, 2020

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting change review labels Oct 3, 2020

bah

21d117e

taleinat added needs backport to 3.8 and removed needs backport to 3.8 labels Oct 3, 2020

taleinat merged commit 5230131 into python:master Oct 3, 2020

bedevere-bot removed the awaiting merge label Oct 3, 2020

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020

bpo-41867: List options for timespec in docstrings of isoformat metho…

ff70df1

…ds (pythonGH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

bedevere-bot removed the needs backport to 3.9 label Oct 3, 2020

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 3, 2020

bpo-41867: List options for timespec in docstrings of isoformat metho…

84ca5e5

…ds (pythonGH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

bedevere-bot removed the needs backport to 3.8 label Oct 3, 2020

miss-islington added a commit that referenced this pull request Oct 3, 2020

bpo-41867: List options for timespec in docstrings of isoformat metho…

9aa34f1

…ds (GH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

taleinat pushed a commit that referenced this pull request Oct 3, 2020

[3.9] bpo-41867: List options for timespec in docstrings of isoformat…

8ca0831

… methods (GH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020

[3.9] bpo-41867: List options for timespec in docstrings of isoformat…

faaa303

… methods (pythonGH-22418) (cherry picked from commit 5230131) Co-authored-by: Ram Rachum <ram@rachum.com>

xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020

bpo-41867: List options for timespec in docstrings of isoformat metho…

b85c4f4

…ds (pythonGH-22418)

Mar	APR	May
	04
2025	2026	2027

Uh oh!

Conversation

cool-RR commented Sep 26, 2020 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taleinat commented Oct 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

taleinat commented Oct 2, 2020

Uh oh!

cool-RR commented Oct 3, 2020

Uh oh!

taleinat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

bedevere-bot commented Oct 3, 2020

Uh oh!

cool-RR commented Oct 3, 2020

Uh oh!

bedevere-bot commented Oct 3, 2020

Uh oh!

taleinat left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

bedevere-bot commented Oct 3, 2020

Uh oh!

cool-RR commented Oct 3, 2020

Uh oh!

bedevere-bot commented Oct 3, 2020

Uh oh!

cool-RR commented Oct 3, 2020

Uh oh!

bedevere-bot commented Oct 3, 2020

Uh oh!

taleinat left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Oct 3, 2020

Uh oh!

bedevere-bot commented Oct 3, 2020

Uh oh!

bedevere-bot commented Oct 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

cool-RR commented Sep 26, 2020 •

edited by bedevere-bot

Loading

taleinat commented Oct 2, 2020 •

edited

Loading