X Tutup
The Wayback Machine - https://web.archive.org/web/20260209114443/https://github.com/nodejs/node/pull/58560
Skip to content

http2: add diagnostics channel 'http2.server.stream.finish'#58560

Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom
RaisinTen:http2-add-diagnostics-channel-http2.server.stream.finish
Jun 4, 2025
Merged

http2: add diagnostics channel 'http2.server.stream.finish'#58560
nodejs-github-bot merged 1 commit intonodejs:mainfrom
RaisinTen:http2-add-diagnostics-channel-http2.server.stream.finish

Conversation

@RaisinTen
Copy link
Member

No description provided.

Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen RaisinTen added the diagnostics_channel Issues and PRs related to diagnostics channel label Jun 2, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Jun 2, 2025
@nodejs-github-bot

This comment was marked as outdated.

@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (eb159a8) to head (8932a4e).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58560      +/-   ##
==========================================
+ Coverage   90.21%   90.24%   +0.02%     
==========================================
  Files         635      635              
  Lines      187586   187596      +10     
  Branches    36852    36857       +5     
==========================================
+ Hits       169233   169295      +62     
+ Misses      11117    11057      -60     
- Partials     7236     7244       +8     
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.57% <100.00%> (+0.01%) ⬆️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas bjohansebas added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 2, 2025
@nodejs-github-bot
Copy link
Collaborator

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 3, 2025
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added commit-queue Add this label to land a pull request using GitHub Actions. semver-minor PRs that contain new features and should be released in the next minor version. labels Jun 3, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 4, 2025
@nodejs-github-bot nodejs-github-bot merged commit 641653b into nodejs:main Jun 4, 2025
81 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 641653b

@RaisinTen RaisinTen deleted the http2-add-diagnostics-channel-http2.server.stream.finish branch June 6, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. diagnostics_channel Issues and PRs related to diagnostics channel http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. semver-minor PRs that contain new features and should be released in the next minor version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup