http: unbreak keepAliveTimeoutBuffer

ronag · targos · commit 2865d2ac2049 · 2025-09-10T15:29:07.000+02:00
Adds a guard. PR-URL: #59784 Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -1025,11 +1025,16 @@ function resOnFinish(req, res, socket, state, server) {
       socket.end();
     }
   } else if (state.outgoing.length === 0) {
-    if (server.keepAliveTimeout && typeof socket.setTimeout === 'function') {
+    const keepAliveTimeout = NumberIsFinite(server.keepAliveTimeout) && server.keepAliveTimeout >= 0 ?
+      server.keepAliveTimeout : 0;
+    const keepAliveTimeoutBuffer = NumberIsFinite(server.keepAliveTimeoutBuffer) && server.keepAliveTimeoutBuffer >= 0 ?
+      server.keepAliveTimeoutBuffer : 1e3;
+
+    if (keepAliveTimeout && typeof socket.setTimeout === 'function') {
       // Extend the internal timeout by the configured buffer to reduce
       // the likelihood of ECONNRESET errors.
       // This allows fine-tuning beyond the advertised keepAliveTimeout.
-      socket.setTimeout(server.keepAliveTimeout + server.keepAliveTimeoutBuffer);
+      socket.setTimeout(keepAliveTimeout + keepAliveTimeoutBuffer);
       state.keepAliveTimeoutSet = true;
     }
   } else {
