src: use string_view in WriteReport()

addaleax · web-flow · commit 3ac88a7a66e6 · 2025-10-12T15:42:54.000Z
Since 075936b, `TriggerNodeReport()` takes `std::string_view` arguments directly. PR-URL: #60201 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
diff --git a/src/node_report_module.cc b/src/node_report_module.cc
@@ -34,18 +34,18 @@ void WriteReport(const FunctionCallbackInfo<Value>& info) {
   Local<Value> error;
 
   CHECK_EQ(info.Length(), 4);
-  String::Utf8Value message(isolate, info[0].As<String>());
-  String::Utf8Value trigger(isolate, info[1].As<String>());
+  Utf8Value message(isolate, info[0].As<String>());
+  Utf8Value trigger(isolate, info[1].As<String>());
 
-  if (info[2]->IsString())
-    filename = *String::Utf8Value(isolate, info[2]);
+  if (info[2]->IsString()) filename = Utf8Value(isolate, info[2]).ToString();
   if (!info[3].IsEmpty())
     error = info[3];
   else
     error = Local<Value>();
 
   // Return value is the report filename
-  filename = TriggerNodeReport(env, *message, *trigger, filename, error);
+  filename = TriggerNodeReport(
+      env, message.ToStringView(), trigger.ToStringView(), filename, error);
   Local<Value> ret;
   if (ToV8Value(env->context(), filename, env->isolate()).ToLocal(&ret)) {
     info.GetReturnValue().Set(ret);
