node-api,test: use local files for instanceof tests
#60190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmoroz
added
test
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60190 +/- ##
=======================================
Coverage 88.55% 88.55%
=======================================
Files 704 704
Lines 208087 208087
Branches 40019 40014 -5
=======================================
+ Hits 184266 184280 +14
+ Misses 15818 15817 -1
+ Partials 8003 7990 -13 🚀 New features to boost your workflow:
|
legendecas
reviewed
Oct 13, 2025
| // The following assert functions are referenced by v8's unit tests | ||
| // See for instance deps/v8/test/mjsunit/instanceof.js | ||
|
|
||
| function assertTrue(assertion) { |
There was a problem hiding this comment.
I think we can update these tests to incorporate Node.js test patterns.
It's unlikely we will sync the these test files from V8 again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make Node-API
instanceoftests independent from V8 code.Currently
test/js-native-api/test_general/testInstanceOf.jstest file depends on two files from the V8 code:deps/v8/test/mjsunit/instanceof.jsdeps/v8/test/mjsunit/instanceof-2.jsWhile it works for the Node.js project, it makes it difficult to reuse these tests for other JS engines and JS runtimes.
In this PR we copy and adapt contents of these two V8 files to
testV8Instanceof.jsandtestV8Instanceof2.jsfiles.These are exactly the same tests as before, but they are now local to the
test/js-native-api/test_generaltest.