gh-139146: Check calloc() results in test_pre_initialization_sys_options #139147
+10
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
picnixz
reviewed
Sep 19, 2025
…s_options Reported by: Dmitrii Chuprov cheese@altlinux.org Signed-off-by: Denis Sergeev zeff@altlinux.org
zeff-ir
force-pushed
the
fix-deref-of-null-testembed
branch
from
b4619e8 to
3be06fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
test_pre_initialization_sys_options()(Programs/_testembed.c),the results of
calloc()were not checked before passing the pointersto
wcsncpy(). On allocation failure (OOM), this could lead to a NULL dereference.This patch adds NULL checks for both allocations and frees already allocated
memory before returning on error.
Fixes gh-139146
skip news