Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
lib: add type names in source mapped stack traces #58976
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
legendecas
force-pushed
the
source-maps/type-name
branch
from
5ed51ea to
a0f517b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58976 +/- ##
==========================================
+ Coverage 89.97% 89.99% +0.02%
==========================================
Files 649 649
Lines 192194 192189 -5
Branches 37678 37678
==========================================
+ Hits 172918 172956 +38
+ Misses 11873 11825 -48
- Partials 7403 7408 +5
🚀 New features to boost your workflow:
|
legendecas
added
lib / src
This comment was marked as outdated.
This comment was marked as outdated.
joyeecheung
approved these changes
Aug 1, 2025
The type name is determined by the constructor name of the receiver in a call site.
legendecas
force-pushed
the
source-maps/type-name
branch
from
a0f517b to
119018c
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Aug 1, 2025
This comment was marked as outdated.
This comment was marked as outdated.
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in f33e0fc |
meteorqz6
pushed a commit
to meteorqz6/node
that referenced
this pull request
Aug 2, 2025
The type name is determined by the constructor name of the receiver in a call site. PR-URL: nodejs#58976 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
panva
pushed a commit
to panva/node
that referenced
this pull request
Aug 7, 2025
The type name is determined by the constructor name of the receiver in a call site. PR-URL: nodejs#58976 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 8, 2025
The type name is determined by the constructor name of the receiver in a call site. PR-URL: #58976 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
mete0rfish
pushed a commit
to mete0rfish/node-contribute
that referenced
this pull request
Aug 9, 2025
The type name is determined by the constructor name of the receiver in a call site. PR-URL: nodejs#58976 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
panva
pushed a commit
to panva/node
that referenced
this pull request
Aug 9, 2025
The type name is determined by the constructor name of the receiver in a call site. PR-URL: nodejs#58976 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 12, 2025
The type name is determined by the constructor name of the receiver in a call site. PR-URL: #58976 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type name is determined by the constructor name of the receiver in a
call site.