test: skip test-fs-cp* tests that are constantly failing on Windows #59637
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are likely actual regressions introduced when the monolithic test-fs-cp.mjs was marked as flaky and got ignored due to the flaky status. They are now constantly failing the Windows CI and require the CI to always be re-run on Windows when the job is resumed. Simply skip them until someone fixes them, as there's no point keep running these known regressions on Windows anymore.
nodejs-github-bot
added
needs-ci
MoLow
approved these changes
Aug 26, 2025
github-actions
bot
removed
the
request-ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59637 +/- ##
==========================================
- Coverage 89.85% 89.83% -0.02%
==========================================
Files 667 667
Lines 196260 196488 +228
Branches 38559 38588 +29
==========================================
+ Hits 176341 176521 +180
- Misses 12368 12423 +55
+ Partials 7551 7544 -7 🚀 New features to boost your workflow:
|
|
Can they potentially be moved to |
|
I don't know how to make the known-issues machinery support platform-specific marking, unless you know how to make it only expect failures on Windows but not on other platforms? |
lpinca
approved these changes
Aug 27, 2025
aduh95
approved these changes
Aug 27, 2025
aduh95
added
author ready
StefanStojanovic
approved these changes
Aug 28, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 2822585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are likely actual regressions introduced when the monolithic test-fs-cp.mjs was marked as flaky and got ignored due to the flaky status. They are now constantly failing the Windows CI and require the CI to always be re-run on Windows when the job is resumed. Simply skip them until someone fixes them, as there's no point keep running these known regressions on Windows anymore.
Refs: #59636
Refs: #59408