X Tutup
The Wayback Machine - https://web.archive.org/web/20250814212455/https://github.com/nodejs/node/pull/59332
Skip to content

doc: rename x509.extKeyUsage to x509.keyUsage #59332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 9, 2025
Merged

doc: rename x509.extKeyUsage to x509.keyUsage #59332

merged 1 commit into from
Aug 9, 2025

Conversation

panva
Copy link
Member

@panva panva commented Aug 2, 2025 •
edited
Loading

This partially reverts #50603. It keeps the description but reverts to use the actual property name. #50603 should not have landed.

node/lib/internal/crypto/x509.js

Lines 270 to 277 in 9bc923a

get keyUsage() {
let value = this[kInternalState].get('keyUsage');
if (value === undefined) {
value = this[kHandle].keyUsage();
this[kInternalState].set('keyUsage', value);
}
return value;
}

@panva panva added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Aug 2, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 3, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 9, 2025
@nodejs-github-bot nodejs-github-bot merged commit a93c1c0 into nodejs:main Aug 9, 2025
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a93c1c0

@panva panva deleted the doc-fix-x509-usage branch August 9, 2025 18:44
RafaelGSS pushed a commit that referenced this pull request Aug 11, 2025
@panva @RafaelGSS
doc: rename x509.extKeyUsage to x509.keyUsage
e0fc66e 
PR-URL: #59332
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Aug 11, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 12, 2025
@panva @RafaelGSS
doc: rename x509.extKeyUsage to x509.keyUsage
fd61588 
PR-URL: #59332
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panva @nodejs-github-bot @jasnell
X Tutup