Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
crypto: prepare webcrypto key import/export for modern algorithms #59284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
panva
force-pushed
the
webcrypto-export-refactor
branch
from
201f541 to
5045296
Compare
panva
changed the title
panva
force-pushed
the
webcrypto-export-refactor
branch
from
5045296 to
890b133
Compare
panva
force-pushed
the
webcrypto-export-refactor
branch
from
890b133 to
dac91a9
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #59284 +/- ##
==========================================
- Coverage 90.01% 89.97% -0.04%
==========================================
Files 649 649
Lines 192182 192208 +26
Branches 37660 37659 -1
==========================================
- Hits 172988 172941 -47
- Misses 11832 11873 +41
- Partials 7362 7394 +32
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Aug 2, 2025
panva
added
the
author ready
RafaelGSS
approved these changes
Aug 5, 2025
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 700a965 |
panva
added a commit
to panva/node
that referenced
this pull request
Aug 7, 2025
PR-URL: nodejs#59284 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 8, 2025
PR-URL: #59284 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
mete0rfish
pushed a commit
to mete0rfish/node-contribute
that referenced
this pull request
Aug 9, 2025
PR-URL: nodejs#59284 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
panva
added a commit
to panva/node
that referenced
this pull request
Aug 9, 2025
PR-URL: nodejs#59284 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 12, 2025
PR-URL: #59284 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does not change any observable behaviour in codes or import/export key results. It refactors the code in preparation for the upcoming https://redirect.github.com/WICG/proposals/issues/220 webcrypto extension.
This will keep the diffs from future modern algos implementation PRs cleaner.