Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
benchmark: remove deprecated _extend from benchmark #59228
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
benchmark
lpinca
approved these changes
Jul 26, 2025
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
RafaelGSS
force-pushed
the
remove-deprecated-extend
branch
from
1b08898 to
8d62018
Compare
RafaelGSS
added
author ready
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/59228 ✔ Done loading data for nodejs/node/pull/59228 ----------------------------------- PR info ------------------------------------ Title benchmark: remove deprecated _extend from benchmark (#59228) Author Rafael Gonzaga <rafael.nunu@hotmail.com> (@RafaelGSS) Branch RafaelGSS:remove-deprecated-extend -> nodejs:main Labels v8 engine, benchmark, author ready Commits 1 - benchmark: remove deprecated _extend from benchmark Committers 1 - RafaelGSS <rafael.nunu@hotmail.com> PR-URL: https://github.com/nodejs/node/pull/59228 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/59228 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - benchmark: remove deprecated _extend from benchmark ℹ This PR was created on Sat, 26 Jul 2025 17:54:21 GMT ✔ Approvals: 1 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59228#pullrequestreview-3058409096 ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/16697407158 |
nodejs-github-bot
added
the
commit-queue-failed
RafaelGSS
added
review wanted
|
Should the benchmark be removed entirely? The benchmark is comparing |
jasnell
approved these changes
Aug 11, 2025
That's right. Also, this kind of benchmark is completely useless since JIT will take place. That's more suitable on https://github.com/RafaelGSS/nodejs-bench-operations. Let me remove it. |
|
PTAL @legendecas @jasnell |
legendecas
approved these changes
Aug 11, 2025
jasnell
approved these changes
Aug 11, 2025
RafaelGSS
added
the
commit-queue
UlisesGascon
approved these changes
Aug 11, 2025
nodejs-github-bot
removed
the
commit-queue
|
Landed in 48aa9c7 |
RafaelGSS
added a commit
that referenced
this pull request
Aug 11, 2025
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #59228 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
RafaelGSS
added a commit
that referenced
this pull request
Aug 12, 2025
Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com> PR-URL: #59228 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as titled