-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
node-api: added SharedArrayBuffer api #59071
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
node-api: added SharedArrayBuffer api #59071
Conversation
|
Review requested:
|
506dc09 to
80236e8
Compare
|
I'm wondering whether it makes sense to limit the use of SharedArrayBuffer for security reasons. For example, if I define and restrict |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59071 +/- ##
==========================================
- Coverage 90.09% 89.90% -0.20%
==========================================
Files 645 655 +10
Lines 189930 192858 +2928
Branches 37217 37808 +591
==========================================
+ Hits 171125 173385 +2260
- Misses 11512 12032 +520
- Partials 7293 7441 +148
🚀 New features to boost your workflow:
|
|
@mertcanaltin , thank you for adding the new APIs for the shared buffer! |
I forgot about this, sorry, updating immediately |
test/js-native-api/test_sharedarraybuffer/test_sharedarraybuffer.c
Outdated
Show resolved
Hide resolved
…er.c Co-authored-by: James M Snell <jasnell@gmail.com>
test/js-native-api/test_sharedarraybuffer/test_sharedarraybuffer.c
Outdated
Show resolved
Hide resolved
test/js-native-api/test_sharedarraybuffer/test_sharedarraybuffer.c
Outdated
Show resolved
Hide resolved
|
Thank you for Rewiev I have made the arrangements @legendecas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, thank you for working on this
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
Co-authored-by: Chengzhong Wu <legendecas@gmail.com>
You are welcome |

Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.

added this features in node-api : #23276