Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
worker: implements nits in Web Locks code #59270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59270 +/- ##
==========================================
- Coverage 89.97% 89.96% -0.01%
==========================================
Files 649 649
Lines 192131 192122 -9
Branches 37653 37651 -2
==========================================
- Hits 172864 172850 -14
- Misses 11883 11889 +6
+ Partials 7384 7383 -1
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jul 29, 2025
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
atlowChemi
approved these changes
Jul 29, 2025
panva
approved these changes
Jul 30, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5ebfb99 |
meteorqz6
pushed a commit
to meteorqz6/node
that referenced
this pull request
Aug 2, 2025
PR-URL: nodejs#59270 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
panva
pushed a commit
to panva/node
that referenced
this pull request
Aug 7, 2025
PR-URL: nodejs#59270 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
targos
pushed a commit
that referenced
this pull request
Aug 8, 2025
PR-URL: #59270 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
mete0rfish
pushed a commit
to mete0rfish/node-contribute
that referenced
this pull request
Aug 9, 2025
PR-URL: nodejs#59270 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
panva
pushed a commit
to panva/node
that referenced
this pull request
Aug 9, 2025
PR-URL: nodejs#59270 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 12, 2025
PR-URL: #59270 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those were missed in #58666, it shouldn't have much runtime effect, it's mainly to make the code more consistent with the rest of the codebase.