Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
test: remove timeout in test-https-proxy-request-handshake-failure #59165
+0
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The timeout is unnecessary since we are testing for certificate failure. It can cause flakes on very slow machines where the request cannot be finished in 1 second.
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #59165 +/- ##
==========================================
- Coverage 90.03% 90.01% -0.02%
==========================================
Files 648 648
Lines 190986 190986
Branches 37437 37440 +3
==========================================
- Hits 171963 171925 -38
- Misses 11638 11682 +44
+ Partials 7385 7379 -6 🚀 New features to boost your workflow:
|
jasnell
approved these changes
Jul 22, 2025
atlowChemi
approved these changes
Jul 22, 2025
github-actions
bot
removed
the
request-ci
MoLow
approved these changes
Jul 22, 2025
lpinca
approved these changes
Jul 23, 2025
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ad07ae6 |
aduh95
pushed a commit
that referenced
this pull request
Jul 25, 2025
The timeout is unnecessary since we are testing for certificate failure. It can cause flakes on very slow machines where the request cannot be finished in 1 second. PR-URL: #59165 Fixes: #59166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The timeout is unnecessary since we are testing for certificate failure. It can cause flakes on very slow machines where the request cannot be finished in 1 second.
Fixes: #59166