doc,lib,src,test: unflag sqlite module

cjihrig · aduh95 · commit efb9f05f59e6 · 2024-11-26T15:34:27.000+01:00
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: #55854 PR-URL: #55890 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
diff --git a/doc/api/cli.md b/doc/api/cli.md
@@ -1079,14 +1079,6 @@ added:
 
 Use this flag to enable [ShadowRealm][] support.
 
-### `--experimental-sqlite`
-
-<!-- YAML
-added: v22.5.0
--->
-
-Enable the experimental [`node:sqlite`][] module.
-
 ### `--experimental-strip-types`
 
 <!-- YAML
@@ -1694,6 +1686,18 @@ Disable support for loading a synchronous ES module graph in `require()`.
 
 See [Loading ECMAScript modules using `require()`][].
 
+### `--no-experimental-sqlite`
+
+<!-- YAML
+added: v22.5.0
+changes:
+  - version: REPLACEME
+    pr-url: https://github.com/nodejs/node/pull/55890
+    description: SQLite is unflagged but still experimental.
+-->
+
+Disable the experimental [`node:sqlite`][] module.
+
 ### `--no-experimental-websocket`
 
 <!-- YAML
@@ -3045,7 +3049,6 @@ one is included in the list below.
 * `--experimental-require-module`
 * `--experimental-shadow-realm`
 * `--experimental-specifier-resolution`
-* `--experimental-sqlite`
 * `--experimental-strip-types`
 * `--experimental-top-level-await`
 * `--experimental-transform-types`
@@ -3081,6 +3084,7 @@ one is included in the list below.
 * `--no-deprecation`
 * `--no-experimental-global-navigator`
 * `--no-experimental-repl-await`
+* `--no-experimental-sqlite`
 * `--no-experimental-websocket`
 * `--no-extra-info-on-fatal-exception`
 * `--no-force-async-hooks-checks`
diff --git a/doc/api/sqlite.md b/doc/api/sqlite.md
@@ -6,8 +6,7 @@
 added: v22.5.0
 -->
 
-> Stability: 1.1 - Active development. Enable this API with the
-> [`--experimental-sqlite`][] CLI flag.
+> Stability: 1.1 - Active development.
 
 <!-- source_link=lib/sqlite.js -->
 
@@ -412,7 +411,6 @@ The following constants are meant for use with [`database.applyChangeset()`](#da
 
 [Changesets and Patchsets]: https://www.sqlite.org/sessionintro.html#changesets_and_patchsets
 [SQL injection]: https://en.wikipedia.org/wiki/SQL_injection
-[`--experimental-sqlite`]: cli.md#--experimental-sqlite
 [`ATTACH DATABASE`]: https://www.sqlite.org/lang_attach.html
 [`PRAGMA foreign_keys`]: https://www.sqlite.org/pragma.html#pragma_foreign_keys
 [`sqlite3_changes64()`]: https://www.sqlite.org/c3ref/changes.html
diff --git a/doc/node.1 b/doc/node.1
@@ -182,9 +182,6 @@ Enable the experimental permission model.
 .It Fl -experimental-shadow-realm
 Use this flag to enable ShadowRealm support.
 .
-.It Fl -experimental-sqlite
-Enable the experimental node:sqlite module.
-.
 .It Fl -experimental-test-coverage
 Enable code coverage in the test runner.
 .
@@ -215,6 +212,9 @@ Enable experimental support for the Web Storage API.
 .It Fl -no-experimental-repl-await
 Disable top-level await keyword support in REPL.
 .
+.It Fl -no-experimental-sqlite
+Disable the experimental node:sqlite module.
+.
 .It Fl -experimental-vm-modules
 Enable experimental ES module support in VM module.
 .
diff --git a/lib/internal/process/pre_execution.js b/lib/internal/process/pre_execution.js
@@ -303,7 +303,7 @@ function setupNavigator() {
 }
 
 function setupSQLite() {
-  if (!getOptionValue('--experimental-sqlite')) {
+  if (getOptionValue('--no-experimental-sqlite')) {
     return;
   }
 
diff --git a/src/node_options.cc b/src/node_options.cc
@@ -427,7 +427,8 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
   AddOption("--experimental-sqlite",
             "experimental node:sqlite module",
             &EnvironmentOptions::experimental_sqlite,
-            kAllowedInEnvvar);
+            kAllowedInEnvvar,
+            true);
   AddOption("--experimental-webstorage",
             "experimental Web Storage API",
             &EnvironmentOptions::experimental_webstorage,
diff --git a/src/node_options.h b/src/node_options.h
@@ -123,7 +123,7 @@ class EnvironmentOptions : public Options {
   bool experimental_eventsource = false;
   bool experimental_fetch = true;
   bool experimental_websocket = true;
-  bool experimental_sqlite = false;
+  bool experimental_sqlite = true;
   bool experimental_webstorage = false;
   std::string localstorage_file;
   bool experimental_global_navigator = true;
diff --git a/test/parallel/test-sqlite-data-types.js b/test/parallel/test-sqlite-data-types.js
@@ -1,4 +1,3 @@
-// Flags: --experimental-sqlite
 'use strict';
 require('../common');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-sqlite-database-sync.js b/test/parallel/test-sqlite-database-sync.js
@@ -1,4 +1,3 @@
-// Flags: --experimental-sqlite
 'use strict';
 require('../common');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-sqlite-named-parameters.js b/test/parallel/test-sqlite-named-parameters.js
@@ -1,4 +1,3 @@
-// Flags: --experimental-sqlite
 'use strict';
 require('../common');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-sqlite-statement-sync.js b/test/parallel/test-sqlite-statement-sync.js
@@ -1,4 +1,3 @@
-// Flags: --experimental-sqlite
 'use strict';
 require('../common');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-sqlite-transactions.js b/test/parallel/test-sqlite-transactions.js
@@ -1,4 +1,3 @@
-// Flags: --experimental-sqlite
 'use strict';
 require('../common');
 const tmpdir = require('../common/tmpdir');
diff --git a/test/parallel/test-sqlite.js b/test/parallel/test-sqlite.js
@@ -1,4 +1,3 @@
-// Flags: --experimental-sqlite
 'use strict';
 const { spawnPromisified } = require('../common');
 const tmpdir = require('../common/tmpdir');
@@ -23,13 +22,14 @@ suite('accessing the node:sqlite module', () => {
     });
   });
 
-  test('cannot be accessed without --experimental-sqlite flag', async (t) => {
+  test('can be disabled with --no-experimental-sqlite flag', async (t) => {
     const {
       stdout,
       stderr,
       code,
       signal,
     } = await spawnPromisified(process.execPath, [
+      '--no-experimental-sqlite',
       '-e',
       'require("node:sqlite")',
     ]);

Original file line number	Diff line number	Diff line change
`@@ -182,9 +182,6 @@ Enable the experimental permission model.`
`182`	`182`	`.It Fl -experimental-shadow-realm`
`183`	`183`	`Use this flag to enable ShadowRealm support.`
`184`	`184`	`.`
`185`		`-.It Fl -experimental-sqlite`
`186`		`-Enable the experimental node:sqlite module.`
`187`		`-.`
`188`	`185`	`.It Fl -experimental-test-coverage`
`189`	`186`	`Enable code coverage in the test runner.`
`190`	`187`	`.`
`@@ -215,6 +212,9 @@ Enable experimental support for the Web Storage API.`
`215`	`212`	`.It Fl -no-experimental-repl-await`
`216`	`213`	`Disable top-level await keyword support in REPL.`
`217`	`214`	`.`
	`215`	`+.It Fl -no-experimental-sqlite`
	`216`	`+Disable the experimental node:sqlite module.`
	`217`	`+.`
`218`	`218`	`.It Fl -experimental-vm-modules`
`219`	`219`	`Enable experimental ES module support in VM module.`
`220`	`220`	`.`
Original file line number	Diff line number	Diff line change
`@@ -303,7 +303,7 @@ function setupNavigator() {`
`303`	`303`	`}`
`304`	`304`
`305`	`305`	`function setupSQLite() {`
`306`		`- if (!getOptionValue('--experimental-sqlite')) {`
	`306`	`+ if (getOptionValue('--no-experimental-sqlite')) {`
`307`	`307`	`return;`
`308`	`308`	`}`
`309`	`309`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-// Flags: --experimental-sqlite`
`2`	`1`	`'use strict';`
`3`	`2`	`require('../common');`
`4`	`3`	`const tmpdir = require('../common/tmpdir');`