async_hooks: add an InactiveAsyncContextFrame class

bengl · aduh95 · commit 027b0ffe8491 · 2024-09-12T11:06:37.000+02:00
This gives a class prototype for AsyncContextFrame that contains the required methods, so that when we swap the prototype, ActiveAsyncContextFrame methods are used instead. Previously, the methods were defined in AsyncContextFrame, so swapping the prototype didn't swap those static methods. Also, make the ActiveAsyncContextFrame extend from Map. Fixes: #54503 PR-URL: #54510 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
diff --git a/lib/internal/async_context_frame.js b/lib/internal/async_context_frame.js
@@ -11,7 +11,7 @@ const {
 
 let enabled_;
 
-class ActiveAsyncContextFrame {
+class ActiveAsyncContextFrame extends Map {
   static get enabled() {
     return true;
   }
@@ -50,12 +50,7 @@ function checkEnabled() {
   return enabled;
 }
 
-class AsyncContextFrame extends Map {
-  constructor(store, data) {
-    super(AsyncContextFrame.current());
-    this.set(store, data);
-  }
-
+class InactiveAsyncContextFrame extends Map {
   static get enabled() {
     enabled_ ??= checkEnabled();
     return enabled_;
@@ -65,6 +60,13 @@ class AsyncContextFrame extends Map {
   static set(frame) {}
   static exchange(frame) {}
   static disable(store) {}
+}
+
+class AsyncContextFrame extends InactiveAsyncContextFrame {
+  constructor(store, data) {
+    super(AsyncContextFrame.current());
+    this.set(store, data);
+  }
 
   disable(store) {
     this.delete(store);
diff --git a/test/parallel/test-async-context-frame.mjs b/test/parallel/test-async-context-frame.mjs
@@ -5,6 +5,7 @@ import { opendir } from 'node:fs/promises';
 import { fileURLToPath } from 'node:url';
 import { describe, it } from 'node:test';
 import { sep } from 'node:path';
+import { strictEqual } from 'node:assert';
 
 const python = process.env.PYTHON || (isWindows ? 'python' : 'python3');
 
@@ -53,7 +54,8 @@ describe('AsyncContextFrame', {
         stdio: ['ignore', 'ignore', 'inherit'],
       });
 
-      await once(proc, 'exit');
+      const [code] = await once(proc, 'exit');
+      strictEqual(code, 0, `Test ${test} failed with exit code ${code}`);
     });
   }
 });
