X Tutup
The Wayback Machine - https://web.archive.org/web/20250624221654/https://github.com/PowerShell/PowerShell/pull/25357
Skip to content

[release/v7.5] Move .NET method invocation logging to after the needed type conversion is done for method arguments #25357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

pwshBot
Copy link
Collaborator

@pwshBot pwshBot commented Apr 14, 2025

Backport of #25022 to release/v7.5

Triggered by @TravisEz13 on behalf of @daxian-dbw

Original CL Label: CL-Engine

/cc @PowerShell/powershell-maintainers

Impact

Choose either tooling or Customer impact.

Tooling Impact

  • Required tooling change
  • Optional tooling change (include reasoning)

Customer Impact

  • Customer reported
  • Found internally

Issue with some parameters to calls not getting logged to AMSI.

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

manually tested by turning on the console log

Risk

  • High
  • Medium
  • Low

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

@TravisEz13 TravisEz13 changed the title [release/v7.5]!!!MERGE_CONFLICT!!! Move .NET method invocation logging to after the needed type conversion is done for method arguments [release/v7.5] Move .NET method invocation logging to after the needed type conversion is done for method arguments Apr 14, 2025
@TravisEz13 TravisEz13 added the CL-Engine Indicates that a PR should be marked as an engine change in the Change Log label Apr 14, 2025
@TravisEz13 TravisEz13 marked this pull request as draft April 14, 2025 22:52
Copy link
Member

@daxian-dbw daxian-dbw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for 1 issue.

@TravisEz13 TravisEz13 marked this pull request as ready for review April 15, 2025 20:38
@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Apr 22, 2025
@TravisEz13
Copy link
Member

/azp run PowerShell-CI-linux-packaging, PowerShell-Windows-Packaging-CI

Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Jun 3, 2025
@TravisEz13 TravisEz13 enabled auto-merge (squash) June 3, 2025 20:07
@TravisEz13 TravisEz13 merged commit bd83cba into PowerShell:release/v7.5 Jun 3, 2025
41 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Jun 3, 2025

📣 Hey @@pwshBot, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackPort-7.5.x-Approved CL-Engine Indicates that a PR should be marked as an engine change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
X Tutup