X Tutup
The Wayback Machine - https://web.archive.org/web/20260114061419/https://github.com/PowerShell/PowerShell/pull/25532
Skip to content

Update links and contribution guide in documentation #25532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
iSazonov merged 9 commits into from
May 17, 2025
Merged

Update links and contribution guide in documentation #25532

iSazonov merged 9 commits into from
May 17, 2025

Conversation

@JustinGrote
Copy link
Contributor

@JustinGrote JustinGrote commented May 9, 2025

Corrected links and improved the contribution guide for clarity and accessibility. Updated instructions for building PowerShell across different platforms.

iSazonov
iSazonov reviewed May 10, 2025
View reviewed changes
@iSazonov iSazonov requested a review from sdwheeler May 10, 2025 05:17
@iSazonov iSazonov added the CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log label May 10, 2025
sdwheeler
sdwheeler suggested changes May 11, 2025
View reviewed changes
@microsoft-github-policy-service microsoft-github-policy-service bot added Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept and removed Waiting on Author The PR was reviewed and requires changes or comments from the author before being accept labels May 11, 2025
@iSazonov
Copy link
Collaborator

iSazonov commented May 13, 2025

@JustinGrote Please look CI errors.

@JustinGrote
Copy link
Contributor Author

JustinGrote commented May 13, 2025

@iSazonov addressed and also added a note about binary modules.

sdwheeler
sdwheeler reviewed May 13, 2025
View reviewed changes
sdwheeler
sdwheeler approved these changes May 13, 2025
View reviewed changes
Copy link
Collaborator

@sdwheeler sdwheeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JustinGrote
Copy link
Contributor Author

JustinGrote commented May 13, 2025

One last Github lint to fix, I can't get to it until later if @sdwheeler you want to commit the change on my behalf, my PRs should be open to reviewer modifications.
image

sdwheeler
sdwheeler reviewed May 13, 2025
View reviewed changes
@iSazonov
Copy link
Collaborator

iSazonov commented May 14, 2025

/azp run PowerShell-CI-linux-packaging,PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

azure-pipelines bot commented May 14, 2025

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@iSazonov
Copy link
Collaborator

iSazonov commented May 14, 2025

@sdwheeler Could you please ask anybody from MSFT team to merge the PR (it is blocked for me since now I last pusher)?

@JustinGrote
Copy link
Contributor Author

JustinGrote commented May 16, 2025 •
edited
Loading

@iSazonov I just rebased so I don't know if that helps, so you can approve and merge outside me. Maybe @andyleejordan can assist with a merge.

@JustinGrote JustinGrote requested review from iSazonov and sdwheeler May 16, 2025 02:19
@iSazonov
Copy link
Collaborator

iSazonov commented May 16, 2025

/azp run PowerShell-CI-linux-packaging,PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

azure-pipelines bot commented May 16, 2025

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@iSazonov
Copy link
Collaborator

iSazonov commented May 16, 2025

@JustinGrote Please add empty commit to unlock the PR.

@JustinGrote JustinGrote requested a review from iSazonov May 16, 2025 05:09
@iSazonov
Copy link
Collaborator

iSazonov commented May 16, 2025

/azp run PowerShell-CI-linux-packaging,PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

azure-pipelines bot commented May 16, 2025

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@JustinGrote JustinGrote requested a review from iSazonov May 17, 2025 16:08
@JustinGrote
Copy link
Contributor Author

JustinGrote commented May 17, 2025 •
edited
Loading

@iSazonov Empty commit didn't seem to work. I made a non-empty commit this time.

@iSazonov
Copy link
Collaborator

iSazonov commented May 17, 2025

/azp run PowerShell-CI-linux-packaging,PowerShell-Windows-Packaging-CI

@azure-pipelines
Copy link

azure-pipelines bot commented May 17, 2025

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@JustinGrote
Copy link
Contributor Author

JustinGrote commented May 17, 2025

@iSazonov AzP didn't run, does the branch name need to rename to not include docs at the beginning?

@iSazonov iSazonov changed the title Docs: Fix links and update contribution guide in documentation Update links and contribution guide in documentation May 17, 2025
@iSazonov iSazonov self-assigned this May 17, 2025
@iSazonov iSazonov merged commit b3ff7ba into PowerShell:master May 17, 2025
36 checks passed
@microsoft-github-policy-service
Copy link
Contributor

microsoft-github-policy-service bot commented May 17, 2025 •
edited by unfurl-links bot
Loading

📣 Hey @@JustinGrote, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@JustinGrote
Copy link
Contributor Author

JustinGrote commented May 17, 2025

@iSazonov thank you!

@JustinGrote JustinGrote deleted the docs/Development branch May 17, 2025 18:07
@ghost ghost mentioned this pull request May 17, 2025
Closed
21 tasks
SIRMARGIN pushed a commit to SIRMARGIN/PowerShell that referenced this pull request Dec 12, 2025
@JustinGrote @SIRMARGIN
Update links and contribution guide in documentation (PowerShell#25532)
3914a30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iSazonov iSazonov iSazonov approved these changes

@sdwheeler sdwheeler Awaiting requested review from sdwheeler

Assignees

@iSazonov iSazonov

Labels

CL-Docs Indicates that a PR should be marked as a documentation change in the Change Log

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JustinGrote @iSazonov @sdwheeler
X Tutup