test: skip node-api/test_worker_terminate_finalization

addaleax · addaleax · commit 335b61ac7411 · 2020-09-22T19:55:25.000+02:00
The test fails under ASAN/valgrind. Since it has not been working properly until today anyway, skip it. Refs: #34731 PR-URL: #34732 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
diff --git a/test/node-api/test_worker_terminate_finalization/test.js b/test/node-api/test_worker_terminate_finalization/test.js
@@ -1,5 +1,10 @@
 'use strict';
 const common = require('../../common');
+
+// TODO(addaleax): Run this test once it stops failing under ASAN/valgrind.
+// Refs: https://github.com/nodejs/node/issues/34731
+common.skip('Reference management in N-API leaks memory');
+
 const { Worker, isMainThread } = require('worker_threads');
 
 if (isMainThread) {
