test: fix wasi/test-return-on-exit on 32-bit systems

cjihrig · targos · commit df93cb47da69 · 2021-05-01T12:25:18.000+02:00
Starting with the V8 8.8 update, this test has been regularly crashing with an out of memory error on 32-bit Windows. The issue has been narrowed down to a function not being bound. This seems like a V8 bug, but at least it seems that we can work around it. Fixes: #37374 PR-URL: #37615 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
diff --git a/test/wasi/test-return-on-exit.js b/test/wasi/test-return-on-exit.js
@@ -21,7 +21,8 @@ const buffer = fs.readFileSync(modulePath);
   // Verify that if a WASI application throws an exception, Node rethrows it
   // properly.
   const wasi = new WASI({ returnOnExit: true });
-  wasi.wasiImport.proc_exit = () => { throw new Error('test error'); };
+  const patchedExit = () => { throw new Error('test error'); };
+  wasi.wasiImport.proc_exit = patchedExit.bind(wasi.wasiImport);
   const importObject = { wasi_snapshot_preview1: wasi.wasiImport };
   const { instance } = await WebAssembly.instantiate(buffer, importObject);
 
