gh-96894: Do not turn echo off for subsequent commands in batch activators #96895
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
Member
|
This seems a bit brittle (e.g. if new lines are added) - can't the echo be turned off and then back on at exit points, rather than almost every line being changed? |
Author
|
Unfortunately, there's no reasonable way to restore the caller's setting when you're done (yeah, batch is crap): |
Author
|
@vsajip ping :) |
Member
|
@python/windows-team |
Author
|
@vsajip ping again! Please approve, assign a different reviewer, or let me know what you would like me to change. |
|
All commit authors signed the Contributor License Agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some
@are certainly unnecessary but I don't feel confident enough to optimize.Closes #96894