build: set --v8-enable-object-print by default

mmarchini · addaleax · commit 380600dbe57e · 2020-09-22T19:55:27.000+02:00
The flag improves the experience of debugging V8 with native debuggers. It doens't incur performance penality, the only downside is an increase in binary size by approximately 248 Kb. Ref: #32834 PR-URL: #34705 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
diff --git a/common.gypi b/common.gypi
@@ -55,6 +55,9 @@
     # Enable disassembler for `--print-code` v8 options
     'v8_enable_disassembler': 1,
 
+    # Sets -dOBJECT_PRINT.
+    'v8_enable_object_print%': 1,
+
     # https://github.com/nodejs/node/pull/22920/files#r222779926
     'v8_enable_handle_zapping': 0,
 
diff --git a/configure.py b/configure.py
@@ -651,7 +651,7 @@
 parser.add_option('--v8-enable-object-print',
     action='store_true',
     dest='v8_enable_object_print',
-    default=False,
+    default=True,
     help='compile V8 with auxiliar functions for native debuggers')
 
 parser.add_option('--node-builtin-modules-path',
