benchmark: always throw the same Error instance

addaleax · addaleax · commit 145691b83ec5 · 2020-09-22T19:54:52.000+02:00
Stack trace capturing currently accounts for 40 % of the benchmark running time. Always throwing the same exception object removes that overhead and lets the benchmark be more focused on what it is supposed to measure. Refs: #34512 (comment) PR-URL: #34523 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
diff --git a/benchmark/async_hooks/promises.js b/benchmark/async_hooks/promises.js
@@ -10,10 +10,11 @@ const bench = common.createBenchmark(main, {
   ]
 });
 
+const err = new Error('foobar');
 async function run(n) {
   for (let i = 0; i < n; i++) {
     await new Promise((resolve) => resolve())
-      .then(() => { throw new Error('foobar'); })
+      .then(() => { throw err; })
       .catch((e) => e);
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -10,10 +10,11 @@ const bench = common.createBenchmark(main, {`
`10`	`10`	`]`
`11`	`11`	`});`
`12`	`12`
	`13`	`+const err = new Error('foobar');`
`13`	`14`	`async function run(n) {`
`14`	`15`	`for (let i = 0; i < n; i++) {`
`15`	`16`	`await new Promise((resolve) => resolve())`
`16`		`- .then(() => { throw new Error('foobar'); })`
	`17`	`+ .then(() => { throw err; })`
`17`	`18`	`.catch((e) => e);`
`18`	`19`	`}`
`19`	`20`	`}`