errors: fully inspect errors on exit

BridgeAR · codebytere · commit e060060aa2a6 · 2020-06-18T09:44:02.000-07:00
This makes sure errors are fully inspected during exit. That is important to provide as many debugging information to the user as possible. Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33523 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/errors.js b/lib/internal/errors.js
@@ -16,6 +16,7 @@ const {
   JSONStringify,
   Map,
   MathAbs,
+  MathMax,
   NumberIsInteger,
   ObjectDefineProperty,
   ObjectKeys,
@@ -700,7 +701,11 @@ const fatalExceptionStackEnhancers = {
                    require('internal/tty').hasColors()) ||
                    defaultColors);
     try {
-      return inspect(error, { colors });
+      return inspect(error, {
+        colors,
+        customInspect: false,
+        depth: MathMax(inspect.defaultOptions.depth, 5)
+      });
     } catch {
       return originalStack;
     }
diff --git a/test/message/assert_throws_stack.out b/test/message/assert_throws_stack.out
@@ -29,6 +29,6 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
       at *
       at *
       at *,
-  expected: [Object],
+  expected: { bar: true },
   operator: 'throws'
 }

Original file line number	Diff line number	Diff line change
`@@ -29,6 +29,6 @@ AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:`
`29`	`29`	`at *`
`30`	`30`	`at *`
`31`	`31`	`at *,`
`32`		`- expected: [Object],`
	`32`	`+ expected: { bar: true },`
`33`	`33`	`operator: 'throws'`
`34`	`34`	`}`