tools: bump the eslint group in /tools/eslint with 5 updates #57261
+124
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://web.archive.org/web/20250308183001im_/https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps the eslint group in /tools/eslint with 5 updates: | Package | From | To | | --- | --- | --- | | [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) | `7.26.7` | `7.26.9` | | [@babel/eslint-parser](https://github.com/babel/babel/tree/HEAD/eslint/babel-eslint-parser) | `7.26.5` | `7.26.8` | | [@stylistic/eslint-plugin-js](https://github.com/eslint-stylistic/eslint-stylistic/tree/HEAD/packages/eslint-plugin-js) | `3.0.1` | `4.1.0` | | [eslint](https://github.com/eslint/eslint) | `9.19.0` | `9.21.0` | | [globals](https://github.com/sindresorhus/globals) | `15.14.0` | `16.0.0` | Updates `@babel/core` from 7.26.7 to 7.26.9 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.9/packages/babel-core) Updates `@babel/eslint-parser` from 7.26.5 to 7.26.8 - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.8/eslint/babel-eslint-parser) Updates `@stylistic/eslint-plugin-js` from 3.0.1 to 4.1.0 - [Release notes](https://github.com/eslint-stylistic/eslint-stylistic/releases) - [Changelog](https://github.com/eslint-stylistic/eslint-stylistic/blob/main/CHANGELOG.md) - [Commits](https://github.com/eslint-stylistic/eslint-stylistic/commits/v4.1.0/packages/eslint-plugin-js) Updates `eslint` from 9.19.0 to 9.21.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v9.19.0...v9.21.0) Updates `globals` from 15.14.0 to 16.0.0 - [Release notes](https://github.com/sindresorhus/globals/releases) - [Commits](sindresorhus/globals@v15.14.0...v16.0.0) --- updated-dependencies: - dependency-name: "@babel/core" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint - dependency-name: "@babel/eslint-parser" dependency-type: direct:production update-type: version-update:semver-patch dependency-group: eslint - dependency-name: "@stylistic/eslint-plugin-js" dependency-type: direct:production update-type: version-update:semver-major dependency-group: eslint - dependency-name: eslint dependency-type: direct:production update-type: version-update:semver-minor dependency-group: eslint - dependency-name: globals dependency-type: direct:production update-type: version-update:semver-major dependency-group: eslint ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
aduh95
approved these changes
Mar 1, 2025
aduh95
added
the
author ready
lpinca
approved these changes
Mar 2, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 187ddb1 |
nodejs-github-bot
deleted the
dependabot/npm_and_yarn/tools/eslint/eslint-75ed76e284
branch
joyeecheung
reviewed
Mar 4, 2025
| "@babel/plugin-syntax-import-attributes": "^7.26.0", | ||
| "@babel/plugin-syntax-import-source": "^7.25.9", | ||
| "@stylistic/eslint-plugin-js": "^3.0.1", | ||
| "eslint": "^9.19.0", | ||
| "@stylistic/eslint-plugin-js": "^4.1.0", |
There was a problem hiding this comment.
This has broken the node-test-linter CI job, because @stylistic/eslint-plugin-js has been changed to ship ESM in v4 and our CI still runs Node.js v20 which does not yet support require(esm) by default: https://ci.nodejs.org/job/node-test-linter/59234/console
|
I think for future dependabot udpates, we should run the CI to prevent this from happening again.. |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 4, 2025
@stylistic/eslint-plugin-js v4 has been updated to ship ESM-only, which needs require(esm) support due to the monkey-patching we do in our eslint.config.mjs. The node-test-linter job in Jenkins still runs Node.js v20 which has not yet released unflagging of require(esm). Revert to use v3 for now until we upgrade the Node.js version used in the CI. PR-URL: #57314 Refs: #57261 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the eslint group in /tools/eslint with 5 updates:
7.26.77.26.97.26.57.26.83.0.14.1.09.19.09.21.015.14.016.0.0Updates
@babel/corefrom 7.26.7 to 7.26.9Release notes
Sourced from
@babel/core's releases.Changelog
Sourced from
@babel/core's changelog.Commits
64bca7bv7.26.94cf5c9e[babel 8] Use@babel/typesfor parser's return type (#17117)fd3f0a8Do not depend on@types/gensyncin Babel 7 (#17127)5315446[babel 8] Remove babel 7-specific imports (#17111)0593941v7.26.81bdb1a4Move@types/gensyncto dependencies (#17105)Updates
@babel/eslint-parserfrom 7.26.5 to 7.26.8Release notes
Sourced from
@babel/eslint-parser's releases.Changelog
Sourced from
@babel/eslint-parser's changelog.... (truncated)
Commits
0593941v7.26.8e02b0ff[Babel 8] Create TSTemplateLiteralType (#17066)Updates
@stylistic/eslint-plugin-jsfrom 3.0.1 to 4.1.0Release notes
Sourced from
@stylistic/eslint-plugin-js's releases.... (truncated)
Changelog
Sourced from
@stylistic/eslint-plugin-js's changelog.... (truncated)
Commits
d3ee9e5chore: release v4.1.0 (main) (#701)668c955feat: addmodule.exportsnamed export forrequire(esm)compatibility (#700)e6dbb9dchore: release v4.0.1 (main) (#694)522e55fchore: release v4.0.0 (main) (#688)c83ce20feat(space-infix-ops): allow to ignore types in ts variant (#684)7cee5ebchore: Update utils for ESM changes (#685)481d54bchore: release v4.0.0-beta.1 (main) (#679)3145d50feat!: migrate to ESM-only, requires ESLint v9+ (#670)6b42973chore: release v3.1.0 (main) (#678)Updates
eslintfrom 9.19.0 to 9.21.0Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
ecd0ede9.21.0a7ef4c7Build: changelog update for 9.21.0a8c9a9fchore: update@eslint/eslintrcand@eslint/js(#19453)265e0cfchore: package.json update for@eslint/jsrelease418717ffeat: introduce new deprecated types for rules (#19238)3401b85test: add test forRule.ReportDescriptortype (#19449)e497aa7chore: update rewrite dependencies (#19448)c5561eadocs: Update READMEdb5340dfix: update missing plugin message template (#19445)d8ffdd4fix: do not exit process on rule crash (#19436)Updates
globalsfrom 15.14.0 to 16.0.0Release notes
Sourced from globals's releases.
Commits
efb324716.0.075cb90aUpdate globals (#285)d018eebFixserviceworkerenvironment name (#284)f9dd683Fix filename case039ed51Add script to get service worker globals (#281)8a43ab615.15.0445df81Regenerate vitest globals (#279)504276bFix "Update" job (#277)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions