X Tutup
The Wayback Machine - https://web.archive.org/web/20241117114148/https://github.com/python/cpython/issues/111999
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add signatures for some builtins #111999

Closed
serhiy-storchaka opened this issue Nov 12, 2023 · 5 comments
Closed

Add signatures for some builtins #111999

serhiy-storchaka opened this issue Nov 12, 2023 · 5 comments
Labels
3.13 bugs and security fixes docs Documentation in the Doc dir interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-feature A feature request or enhancement

Comments

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Nov 12, 2023 •
edited by bedevere-app bot
Loading

Feature or enhancement

Signature can be manually added for some builtin functions and classes that do not use Argument Clinic.

Linked PRs
@serhiy-storchaka serhiy-storchaka added type-feature A feature request or enhancement docs Documentation in the Doc dir interpreter-core (Objects, Python, Grammar, and Parser dirs) 3.13 bugs and security fixes labels Nov 12, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue Nov 12, 2023
@serhiy-storchaka
pythongh-111999: Add signatures and improve docstrings for builtins
65d3c75
@bedevere-app bedevere-app bot mentioned this issue Nov 12, 2023
Merged
@serhiy-storchaka serhiy-storchaka mentioned this issue Nov 12, 2023
Closed
@serhiy-storchaka
Copy link
Member Author

This change exposed a bug in a test: #112001.

serhiy-storchaka added a commit that referenced this issue Nov 13, 2023
@serhiy-storchaka
gh-111999: Add signatures and improve docstrings for builtins (GH-112000
1d75ef6 
)
aisk pushed a commit to aisk/cpython that referenced this issue Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-111999: Add signatures and improve docstrings for builtins (p…
151b318 
…ythonGH-112000)
@JelleZijlstra
Copy link
Member

The signature for .format_map() is now incorrect:

>>> str.format_map.__text_signature__
'($self, /, mapping)'
>>> "x".format_map(mapping={})
Traceback (most recent call last):
  File "<python-input-1>", line 1, in <module>
    "x".format_map(mapping={})
    ~~~~~~~~~~~~~~^^^^^^^^^^^^
TypeError: str.format_map() takes no keyword arguments

@JelleZijlstra JelleZijlstra reopened this May 24, 2024
@JelleZijlstra JelleZijlstra mentioned this issue May 24, 2024
Merged
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this issue May 25, 2024
@serhiy-storchaka
pythongh-111999: Fix the signature of str.format_map()
0858169
@serhiy-storchaka
Copy link
Member Author

Thank you for catching this @JelleZijlstra.

@bedevere-app bedevere-app bot mentioned this issue May 25, 2024
Merged
JelleZijlstra pushed a commit that referenced this issue May 25, 2024
@serhiy-storchaka
gh-111999: Fix the signature of str.format_map() (#119540)
08e6543
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 25, 2024
@serhiy-storchaka @miss-islington
pythongh-111999: Fix the signature of str.format_map() (pythonGH-119540)
e809618 
(cherry picked from commit 08e6543)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app bedevere-app bot mentioned this issue May 25, 2024
Merged
JelleZijlstra pushed a commit that referenced this issue May 25, 2024
@miss-islington @serhiy-storchaka
[3.13] gh-111999: Fix the signature of str.format_map() (GH-119540) (#…
f49749c 
…119543)

(cherry picked from commit 08e6543)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@JelleZijlstra JelleZijlstra mentioned this issue May 28, 2024
Closed
@encukou
Copy link
Member

encukou commented May 28, 2024

Is there more to do here?

@JelleZijlstra
Copy link
Member

Thanks @serhiy-storchaka for the quick fix!

estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@serhiy-storchaka @estyxx
pythongh-111999: Fix the signature of str.format_map() (python#119540)
5dd63d9
@sobolevn sobolevn mentioned this issue Aug 29, 2024
Closed
Glyphack pushed a commit to Glyphack/cpython that referenced this issue Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-111999: Add signatures and improve docstrings for builtins (p…
a7d16d9 
…ythonGH-112000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes docs Documentation in the Doc dir interpreter-core (Objects, Python, Grammar, and Parser dirs) release-blocker type-feature A feature request or enhancement
Projects
Release and Deferred blockers 🚫
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@encukou @JelleZijlstra @serhiy-storchaka
X Tutup