X Tutup
The Wayback Machine - https://web.archive.org/web/20241127033551/https://github.com/PowerShell/PowerShell/pull/24528
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to use only NuGet feed sources #24528

Merged
merged 4 commits into from
Oct 31, 2024

Conversation

TravisEz13
Copy link
Member

@TravisEz13 TravisEz13 commented Oct 31, 2024

PR Summary

This pull request includes updates to the build.psm1 script, several nuget.config files, and the tools/findMissingNotices.ps1 script. The changes introduce a new source option, update package source URLs, and fix a regex pattern.

Updates to build.psm1:

  • Added 'NuGetOnly' to the ValidateSet for the $Source parameter in the Switch-PSNugetConfig function.
  • Updated the Switch-PSNugetConfig function to handle the new 'NuGetOnly' source option.

Updates to nuget.config files:

  • Changed the PowerShell package source URL in nuget.config, src/Modules/nuget.config, and test/tools/Modules/nuget.config to remove the preview test version.

Updates to tools/findMissingNotices.ps1:

  • Added a check to ensure the key does not already exist in the $existingRegistrationTable before adding a new entry.
  • Fixed a regex pattern in the ConvertTo-SemVer function to correctly match the version format.

PR Context

PR Checklist

@TravisEz13 TravisEz13 force-pushed the add-mode-for-updating-packages branch from b0bede2 to 2ef5e4d Compare October 31, 2024 19:32
@TravisEz13 TravisEz13 changed the title Update build.psm1 Add a way to use only NuGet feed sources Oct 31, 2024
@TravisEz13 TravisEz13 marked this pull request as ready for review October 31, 2024 19:33
@TravisEz13 TravisEz13 enabled auto-merge (squash) October 31, 2024 19:33
@TravisEz13 TravisEz13 added the CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log label Oct 31, 2024
@TravisEz13 TravisEz13 self-assigned this Oct 31, 2024
@TravisEz13 TravisEz13 merged commit adac4c7 into master Oct 31, 2024
45 checks passed
@TravisEz13 TravisEz13 deleted the add-mode-for-updating-packages branch October 31, 2024 20:13
Copy link
Contributor

microsoft-github-policy-service bot commented Oct 31, 2024

📣 Hey @TravisEz13, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

adityapatwardhan pushed a commit to adityapatwardhan/PowerShell that referenced this pull request Oct 31, 2024
* Update build.psm1

* update default feeds

* fix issue with cgmanifest having duplicate existing entries

* update pattern
TravisEz13 added a commit to TravisEz13/PowerShell that referenced this pull request Nov 4, 2024
* Update build.psm1

* update default feeds

* fix issue with cgmanifest having duplicate existing entries

* update pattern
TravisEz13 added a commit that referenced this pull request Nov 4, 2024
* Update build.psm1

* update default feeds

* fix issue with cgmanifest having duplicate existing entries

* update pattern
jshigetomi pushed a commit to jshigetomi/PowerShell that referenced this pull request Nov 14, 2024
* Update build.psm1

* update default feeds

* fix issue with cgmanifest having duplicate existing entries

* update pattern
ader1990 pushed a commit to ader1990/PowerShell that referenced this pull request Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BackPort-7.4.x-Done BackPort-7.5.x-Done CL-BuildPackaging Indicates that a PR should be marked as a build or packaging change in the Change Log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
X Tutup