Change type of LineNumber to ulong in Select-String #24075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very long files could overflow the LineNumber, leading to negative line numbers in output of Select-String. Changing to UInt64 should fix this for the forseeable future
iSazonov
added
Review - Committee
|
We need WG conclusion and Committee approval for public API change. |
microsoft-github-policy-service
bot
removed
the
Review - Needed
Anything I need to do? |
SteveL-MSFT
added
WG-NeedsReview
|
I'll queue this up for next WG review (1st Wed of the month) |
microsoft-github-policy-service
bot
added
the
Review - Needed
|
The @PowerShell/wg-powershell-cmdlets reviewed this. We believe this is a bucket 3 breaking change that is unlikely to impact real world usage. This would immediately address PowerShell script users and any unlikely C# usage would know how to fix their code to work against this change. |
SteveL-MSFT
added
WG-Reviewed
microsoft-github-policy-service
bot
removed
the
Review - Needed
SteveL-MSFT
approved these changes
Aug 7, 2024
iSazonov
added
the
CL-General
iSazonov
changed the title
|
📣 Hey @Snowman-25, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
|
@Snowman-25 Thanks for your contribution. |
chrisdent-de
pushed a commit
to chrisdent-de/PowerShell
that referenced
this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very long files could overflow the LineNumber, leading to negative line numbers in output of Select-String. Changing to UInt64 should fix this for the forseeable future
PR Summary
See Commit message: Fix for negative LineNumbers in Output of Select-String
PR Context
See Issue #24027
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).