X Tutup
The Wayback Machine - https://web.archive.org/web/20250425010158/https://github.com/PowerShell/PowerShell/pull/24192
Skip to content

Remove trailing space from event source name #24192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

MartinGC94
Copy link
Contributor

PR Summary

Fixes the GetHelpCommand trace source name so it doesn't include a trailing space.
The trailing space meant that you had to quote it with the space to get it show up properly:

$null = Get-Help about_pester
Get-TraceSource -Name "GetHelpCommand "

I guess technically it's a breaking change but it's unlikely that anyone depends on this behavior.

PR Context

PR Checklist

@SteveL-MSFT SteveL-MSFT added WG-Engine core PowerShell engine, interpreter, and runtime WG-NeedsReview Needs a review by the labeled Working Group labels Aug 26, 2024
@SteveL-MSFT
Copy link
Member

I took a look and WinPS5.1 has this same issue. I would tend to agree this is a Bucket 3, but leaving it to Engine WG to decide

@microsoft-github-policy-service microsoft-github-policy-service bot added the Review - Needed The PR is being reviewed label Sep 2, 2024
@daxian-dbw

This comment was marked as outdated.

This comment was marked as outdated.

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Review - Needed The PR is being reviewed label Feb 10, 2025
@rkeithhill
Copy link
Collaborator

The Engine WG discussed this today and approve this fix. A quick search of GitHub.com for "\"GetHelpCommand \"" finds the original bug and just forks of the original bug in HelpCommand.cs. The WG agrees with the bucket 3 assessment, and that this change is unlikely to cause issues.

@iSazonov

This comment was marked as outdated.

This comment was marked as outdated.

@iSazonov iSazonov added the CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log label Feb 11, 2025
@iSazonov iSazonov self-assigned this Feb 11, 2025
@iSazonov iSazonov merged commit 9941e38 into PowerShell:master Feb 11, 2025
39 of 41 checks passed
Copy link
Contributor

microsoft-github-policy-service bot commented Feb 11, 2025

📣 Hey @MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️

🔗 https://aka.ms/PSRepoFeedback

@MartinGC94 MartinGC94 deleted the FixTraceSourceName branch February 11, 2025 07:58
@daxian-dbw daxian-dbw added the Breaking-Change breaking change that may affect users label Feb 21, 2025
@jshigetomi jshigetomi added CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log and removed CL-General Indicates that a PR should be marked as a general cmdlet change in the Change Log labels Feb 21, 2025
@rkeithhill rkeithhill added WG-Reviewed A Working Group has reviewed this and made a recommendation WG-Triaged The issue has been triaged by the designated WG. and removed WG-NeedsReview Needs a review by the labeled Working Group WG-Triaged The issue has been triaged by the designated WG. labels Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking-Change breaking change that may affect users CL-BreakingChange Indicates that a PR should be marked as a breaking change in the Change Log WG-Engine core PowerShell engine, interpreter, and runtime WG-Reviewed A Working Group has reviewed this and made a recommendation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants
X Tutup