-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Remove trailing space from event source name #24192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I took a look and WinPS5.1 has this same issue. I would tend to agree this is a Bucket 3, but leaving it to Engine WG to decide |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
The Engine WG discussed this today and approve this fix. A quick search of GitHub.com for |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
📣 Hey @MartinGC94, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |


PR Summary
Fixes the
GetHelpCommandtrace source name so it doesn't include a trailing space.The trailing space meant that you had to quote it with the space to get it show up properly:
I guess technically it's a breaking change but it's unlikely that anyone depends on this behavior.
PR Context
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.- [ ] Issue filed:
(which runs in a different PS Host).