New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Format-Table where header label is empty
#21156
Conversation
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
src/System.Management.Automation/FormatAndOutput/common/FormatViewGenerator_Table.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.


PR Summary
With the addition of the feature to add italics to table headers that are synthetic, the code that checks this was simply passing the header label to PSObject to see if the property exists. However, PSObject doesn't allow for an empty string as the property name so throws an exception rather than returning null.
This is a regression introduced in 7.4
Fix is to check if the label text is empty before attempting to retrieve the property to see if it exists.
PR Context
Fix #21147
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.(which runs in a different PS Host).