src: expose LookupAndCompile with parameters
#53886
Merged
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
codebytere
force-pushed
the
lookup-compile
branch
from
01341f6
to
d9fcce2
Compare
joyeecheung
approved these changes
Jul 25, 2024
legendecas
approved these changes
Jul 26, 2024
github-actions
bot
removed
the
request-ci
|
@Ethan-Arrowood given none of the rest of LookupAndCompile is tested, where did you envision testing this? |
jasnell
approved these changes
Jul 29, 2024
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in c40c41c |
targos
pushed a commit
that referenced
this pull request
Jul 30, 2024
PR-URL: #53886 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
RafaelGSS
pushed a commit
that referenced
this pull request
Aug 5, 2024
PR-URL: #53886 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #44018.
This PR exposes a version of
LookupAndCompilethat takes parameters instead of detecting them based on module IDs.Electron currently maintains a wrapper to
LookupAndCompile, which specifically requires parameters because we pass our own modules toLookupAndCompilein several places:shell/common/api/electron_api_asar.ccshell/renderer/electron_sandboxed_renderer_client.ccshell/renderer/renderer_client_base.ccand therefore need to be able to able to expose the ability to set that.