-
-
Notifications
You must be signed in to change notification settings - Fork 33k
[Doc] Fix os.spawn* functions #121094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[Doc] Fix os.spawn* functions #121094
Conversation
…#106335) Remove private _PyThreadState and _PyInterpreterState C API functions: move them to the internal C API (pycore_pystate.h and pycore_interp.h). Don't export most of these functions anymore, but still export functions used by tests. Remove _PyThreadState_Prealloc() and _PyThreadState_Init() from the C API, but keep it in the stable API.
This reverts commit ebfa093.
|
The reason why
In particular, the semantics of path and file are distinct. Concerning the code source of Python itself, I think that's the one that should be changed (and not the docs themselves in this case). However, we could be a bit more precise in the docs (but for that, I'd check the C code first). |
Here the problem is the consequences. See this @gpshead's comment: https://discuss.python.org/t/is-time-to-remove-os-module-spawn-functions/55829/7 |
|
Oh actually I got misleaded! Actually, those ones have indeed nothing to do with
While my previous comment was incorrect, the rationale of why those names were used is probably what I thought about. |
Replace argument names *path* for *file*, the real names from them
e54d2ca to
36d122e
Compare
The problem is not in the function definition. There all A similar problem occurs with |


This PR makes the documentation more suitable with the functions definitions in the source code and removes a inconsistency when the reader reads
filein the functions assignature, but the first line below citespath.📚 Documentation preview 📚: https://cpython-previews--121094.org.readthedocs.build/