docs: add a more precise example#121015
Merged
willingc merged 4 commits intopython:mainfrom Nov 1, 2024
Merged
Conversation
Previous example used manual integer value assignment in class based declaration but in functional syntax has been used auto value assignment what could be confusing for the new users. Additionally documentation doesn't show how to declare new enum via functional syntax with usage of the manual value assignment.
|
All commit authors signed the Contributor License Agreement. |
bedevere-app
bot
added
docs
ethanfurman
requested changes
Jul 15, 2024
Member
ethanfurman
left a comment
ethanfurman
left a comment
There was a problem hiding this comment.
Most of the changes are not necessary. I would accept a second example, similar to your proposed example, of ...[('RED', 1), ('GREEN', 2), ....
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Contributor
Author
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @ethanfurman: please review the changes made to this pull request. |
Contributor
|
@ethanfurman I'm triaging open doc PRs. Do you want to review this one again? Thanks! |
willingc
approved these changes
Oct 31, 2024
ethanfurman
approved these changes
Nov 1, 2024
willingc
approved these changes
Nov 1, 2024
Contributor
willingc
left a comment
willingc
left a comment
There was a problem hiding this comment.
Thanks @ethanfurman for the new review and @Ret2Me for the contribution.
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 1, 2024
* docs: add a more precise example Previous example used manual integer value assignment in class based declaration but in functional syntax has been used auto value assignment what could be confusing for the new users. Additionally documentation doesn't show how to declare new enum via functional syntax with usage of the manual value assignment. * docs: remove whitespace characters * refactor: change example --------- (cherry picked from commit ff257c7) Co-authored-by: Filip "Ret2Me" Poplewski <37419029+Ret2Me@users.noreply.github.com> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 1, 2024
* docs: add a more precise example Previous example used manual integer value assignment in class based declaration but in functional syntax has been used auto value assignment what could be confusing for the new users. Additionally documentation doesn't show how to declare new enum via functional syntax with usage of the manual value assignment. * docs: remove whitespace characters * refactor: change example --------- (cherry picked from commit ff257c7) Co-authored-by: Filip "Ret2Me" Poplewski <37419029+Ret2Me@users.noreply.github.com> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
|
GH-126306 is a backport of this pull request to the 3.13 branch. |
|
GH-126307 is a backport of this pull request to the 3.12 branch. |
willingc
pushed a commit
that referenced
this pull request
Nov 1, 2024
) docs: add a more precise example in enum doc (GH-121015) * docs: add a more precise example Previous example used manual integer value assignment in class based declaration but in functional syntax has been used auto value assignment what could be confusing for the new users. Additionally documentation doesn't show how to declare new enum via functional syntax with usage of the manual value assignment. * docs: remove whitespace characters * refactor: change example --------- (cherry picked from commit ff257c7) Co-authored-by: Filip "Ret2Me" Poplewski <37419029+Ret2Me@users.noreply.github.com> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
willingc
pushed a commit
that referenced
this pull request
Nov 1, 2024
) docs: add a more precise example in enum doc (GH-121015) * docs: add a more precise example Previous example used manual integer value assignment in class based declaration but in functional syntax has been used auto value assignment what could be confusing for the new users. Additionally documentation doesn't show how to declare new enum via functional syntax with usage of the manual value assignment. * docs: remove whitespace characters * refactor: change example --------- (cherry picked from commit ff257c7) Co-authored-by: Filip "Ret2Me" Poplewski <37419029+Ret2Me@users.noreply.github.com> Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
* docs: add a more precise example Previous example used manual integer value assignment in class based declaration but in functional syntax has been used auto value assignment what could be confusing for the new users. Additionally documentation doesn't show how to declare new enum via functional syntax with usage of the manual value assignment. * docs: remove whitespace characters * refactor: change example --------- Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
* docs: add a more precise example Previous example used manual integer value assignment in class based declaration but in functional syntax has been used auto value assignment what could be confusing for the new users. Additionally documentation doesn't show how to declare new enum via functional syntax with usage of the manual value assignment. * docs: remove whitespace characters * refactor: change example --------- Co-authored-by: Ethan Furman <ethan@stoneleaf.us>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous example used manual integer value assignment in class based declaration but in functional syntax has been used auto value assignment what could be confusing for the new users.
Additionally documentation doesn't show how to declare new enum via functional syntax with usage of the manual value assignment.
📚 Documentation preview 📚: https://cpython-previews--121015.org.readthedocs.build/