Add back 2 transitive dependency packages #21415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daxian-dbw
requested review from
TravisEz13,
adityapatwardhan and
anmenaga
as code owners
daxian-dbw
added
CL-BuildPackaging
|
Interesting, how many dependencies does pwsh have? Is it worth keeping track of this to avoid regression? |
FWIW we do run a tool as part of the release to check for transitive updates. It's only major versions that we'll potentially miss - but usually we don't necessarily want to take those anyway. The ones we do want to take should be pretty rare. |
|
📣 Hey @daxian-dbw, how did we do? We would love to hear your feedback with the link below! 🗣️ 🔗 https://aka.ms/PSRepoFeedback |
SeeminglyScience
pushed a commit
that referenced
this pull request
Apr 11, 2024
… SDK + dependencies and cgmanifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix #21324
Explicitly put those 2 transitive dependencies back to
Microsoft.PowerShell.SDK.csproj.Due to the removal of them, PS v7.4 ships old versions of the assembly
Microsoft.Bcl.AsyncInterfaces.dllandMicrosoft.Extensions.ObjectPool.dllcomparing to PS v7.3.After adding back the references, PS will includes the latest stable versions:
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.