X Tutup
The Wayback Machine - https://web.archive.org/web/20240906213326/https://github.com/python/cpython/issues/119727
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --single-process option to regrtest to always run tests sequentially (ignore -jN option) #119727

Closed
vstinner opened this issue May 29, 2024 · 5 comments
Closed

Add --single-process option to regrtest to always run tests sequentially (ignore -jN option) #119727

vstinner opened this issue May 29, 2024 · 5 comments
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement

Comments

@vstinner
Copy link
Member

vstinner commented May 29, 2024 •
edited by bedevere-app bot
Loading

The Python release process runs tests sequentially. It catchs some issues which are ignored silently when running tests in parallel.

I propose adding --sequentially option to regrtest to always run tests sequentially. It can be used to ignore any -jN option and also to re-run failed tests sequentially.

Linked PRs
vstinner added a commit to vstinner/cpython that referenced this issue May 29, 2024
@vstinner
pythongh-119727: Add --sequentially option to regrtest
d387ad7
vstinner added a commit to vstinner/cpython that referenced this issue May 29, 2024
@vstinner
pythongh-119727: Add --sequentially option to regrtest
ef0522a
@bedevere-app bedevere-app bot mentioned this issue May 29, 2024
Merged
@vstinner vstinner mentioned this issue May 29, 2024
Merged
@vstinner
Copy link
Member Author

My motivation for this change is also a desire to change the regrtest default to -j0: run tests in parallel using the number of CPU.

@Eclips4 Eclips4 added tests Tests in the Lib/test dir type-feature A feature request or enhancement labels May 29, 2024
@serhiy-storchaka
Copy link
Member

This is an opposite of --multiprocess. Why not call it --singleprocess?

You can run tests with -j1, it will be sequentially, but in different processes.

@vstinner
Copy link
Member Author

IMO "sequentially" is the right name. --multiprocess means in fact "running tests in parallel". Using multipe processes is just an implementation details. It could be threads or something else. The opposite of parallel is sequential. IMO it's too late to rename the --multiprocess option.

Note: there is already a --single option. --singleprocess sounds too close.

@serhiy-storchaka
Copy link
Member

I will not insist.

The --multiprocess option has two effects: it runs the tests in parallel and runs every test is a separate process. It could be possible to run the tests in parallel using the process pull, but this is not how it is implemented now, and I do not think there is a benefit to implement such option. Currently there are three options:

  • Run the tests sequentially in the same (main) process. By default.
  • Run the tests sequentially in separate processes. -j1.
  • Run the tests in parallel in separate processes. -jN.

vstinner added a commit that referenced this issue Jun 3, 2024
@vstinner
gh-119727: Add --single-process option to regrtest (#119728)
4e8aa32
@hugovk hugovk changed the title Add --sequentially option to regrtest to always run tests sequentially (ignore -jN option) Add --single-process option to regrtest to always run tests sequentially (ignore -jN option) Jun 3, 2024
mliezun pushed a commit to mliezun/cpython that referenced this issue Jun 3, 2024
@vstinner @mliezun
pythongh-119727: Add --single-process option to regrtest (python#119728)
035ef28
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
@vstinner @barneygale
pythongh-119727: Add --single-process option to regrtest (python#119728)
713d900
vstinner added a commit to vstinner/cpython that referenced this issue Jun 13, 2024
@vstinner
pythongh-119727: Run tests in parallel by default
6b1d321 
Python test runner (regrtest) now runs tests in parallel by default.
Use the --single-process option to run tests sequentially in a single
process.
vstinner added a commit to vstinner/cpython that referenced this issue Jun 13, 2024
@vstinner
pythongh-119727: Run tests in parallel by default
ddb22a6 
Python test runner (regrtest) now runs tests in parallel by default.
Use the --single-process option to run tests sequentially in a single
process.
vstinner added a commit to vstinner/cpython that referenced this issue Jun 13, 2024
@vstinner
pythongh-119727: Run tests in parallel by default
5517f14 
The Python test runner (regrtest) now runs tests in parallel by
default.  Use the --single-process option to run tests sequentially
in a single process.
@bedevere-app bedevere-app bot mentioned this issue Jun 13, 2024
Closed
@vstinner
Copy link
Member Author

Implemented by change 4e8aa32.

noahbkim pushed a commit to hudson-trading/cpython that referenced this issue Jul 11, 2024
@vstinner @noahbkim
pythongh-119727: Add --single-process option to regrtest (python#119728)
dea4632
estyxx pushed a commit to estyxx/cpython that referenced this issue Jul 17, 2024
@vstinner @estyxx
pythongh-119727: Add --single-process option to regrtest (python#119728)
7dd93f0
mhsmith pushed a commit to mhsmith/cpython that referenced this issue Aug 14, 2024
@vstinner @mhsmith
pythongh-119727: Add --single-process option to regrtest (python#119728)
4185f2b 
(cherry picked from commit 4e8aa32)
@bedevere-app bedevere-app bot mentioned this issue Aug 14, 2024
Merged
vstinner added a commit that referenced this issue Aug 26, 2024
@mhsmith @vstinner
[3.13] gh-119727: Add --single-process option to regrtest (#119728) (#…
350313e 
…123010)

gh-119727: Add --single-process option to regrtest (#119728)

(cherry picked from commit 4e8aa32)

Co-authored-by: Victor Stinner <vstinner@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tests Tests in the Lib/test dir type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@vstinner @serhiy-storchaka @Eclips4
X Tutup