gh-118609: Add proper error check for framelocalsproxy#118615
Merged
gvanrossum merged 2 commits intopython:mainfrom May 6, 2024
Merged
gh-118609: Add proper error check for framelocalsproxy#118615gvanrossum merged 2 commits intopython:mainfrom
gvanrossum merged 2 commits intopython:mainfrom
Conversation
gvanrossum
approved these changes
May 6, 2024
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Thanks! One style nit, you can fix it or leave it.
(Maybe @sobolevn can review too, in case I missed anything -- I realize I am not up to speed with all the details of writing this kind of code any more.)
Objects/frameobject.c
Outdated
Comment on lines
383
to
385
Member
There was a problem hiding this comment.
I'd swap these two lines, so that the Py_ReprEnter/Leave and the PyDict_New/Py_DECREF "brackets" properly nest. But this works too of course.
Member
Author
There was a problem hiding this comment.
Yeah that makes sense. DECREF dct as soon as we are done with it and then leave repr. Fixed it.
Member
Member
|
I'll merge everything Monday morning (Pacific time) unless anyone says otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
frameobject.cObjects/frameobject.clacks error-checking #118609