X Tutup
The Wayback Machine - https://web.archive.org/web/20240502102209/https://github.com/python/cpython/pull/107962
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking 鈥淪ign up for GitHub鈥, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-103363: Add follow_symlinks argument to pathlib.Path.owner() and group() #107962

Merged
merged 10 commits into from Dec 4, 2023

Conversation

kamilturek
Copy link
Contributor

@kamilturek kamilturek commented Aug 15, 2023

@kamilturek kamilturek changed the title gh-103363: Add follow_symlink argument to pathlib.Path.owner() and group() gh-103363: Add follow_symlinks argument to pathlib.Path.owner() and group() Aug 15, 2023
@kamilturek kamilturek marked this pull request as ready for review August 15, 2023 11:27
@AA-Turner

This comment was marked as resolved.

Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me ages to review. Overall looks really good, thank you. Could you merge in the latest main? You'll find there's a new _PathBase class with its own owner() and group() methods - please add the follow_symlinks argument there too. Thanks again!

Lib/test/test_pathlib.py Outdated Show resolved Hide resolved
@bedevere-app
Copy link

bedevere-app bot commented Nov 26, 2023

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@kamilturek
Copy link
Contributor Author

Hey @barneygale. Thanks for the review. That's really appreciated.

I have made the requested changes; please review again

@kamilturek
Copy link
Contributor Author

I have made the requested changes; please review again

Copy link
Contributor

@barneygale barneygale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smashing, thanks so much

@barneygale barneygale merged commit a1551b4 into python:main Dec 4, 2023
30 of 31 checks passed
@kamilturek kamilturek deleted the gh-103363 branch December 4, 2023 21:14
@kamilturek kamilturek restored the gh-103363 branch December 4, 2023 21:14
@kamilturek kamilturek deleted the gh-103363 branch December 4, 2023 21:14
@kamilturek kamilturek restored the gh-103363 branch December 4, 2023 21:20
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants
X Tutup