X Tutup
The Wayback Machine - https://web.archive.org/web/20200918095503/https://github.com/PowerShell/PSScriptAnalyzer/pull/1446
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CompatibilityCollector able to parse a single version String #1446

Merged

Conversation

@bergmeister
Copy link
Collaborator

bergmeister commented Apr 17, 2020

PR Summary

Make CompatibilityCollector able to parse a single version String.
I found it odd that the version number is -1 when not being specified (System.Management.Automation.SemanticVersion uses a 0 in that case) but I tried to be at least consistent with the current implementation...

PR Checklist

@rjmholt
Copy link
Member

rjmholt commented Apr 17, 2020

Thanks for this @bergmeister!

@bergmeister
Copy link
Collaborator Author

bergmeister commented Apr 17, 2020

You're welcome, it was a relatively easy fix

@bergmeister bergmeister merged commit a694480 into PowerShell:master Apr 17, 2020
12 checks passed
12 checks passed
PSScriptAnalyzer-CI Build #20200417.3 succeeded
Details
PSScriptAnalyzer-CI (Build Full_Build) Build Full_Build succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_16_04) Test Ubuntu_16_04 succeeded
Details
PSScriptAnalyzer-CI (Test Ubuntu_18_04) Test Ubuntu_18_04 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_5_1) Test Windows_Server2016_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2016_PowerShell_Core) Test Windows_Server2016_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_5_1) Test Windows_Server2019_PowerShell_5_1 succeeded
Details
PSScriptAnalyzer-CI (Test Windows_Server2019_PowerShell_Core) Test Windows_Server2019_PowerShell_Core succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_14_Mojave) Test macOS_10_14_Mojave succeeded
Details
PSScriptAnalyzer-CI (Test macOS_10_15_Catalina) Test macOS_10_15_Catalina succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla All CLA requirements met.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.
X Tutup