C#: Limit extracted compilation and extraction messages #15957
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
commented
Mar 18, 2024
csharp/extractor/Semmle.Extraction.CSharp/Entities/Compilations/CompilerDiagnostic.cs
Show resolved
Hide resolved
![github-advanced-security[bot]](https://web.archive.org/web/20260105003829im_/https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| protected override void Populate(TextWriter trapFile) | ||
| { | ||
| // The below doesn't limit the extractor messages to the exact limit, but it's good enough. | ||
| Interlocked.Increment(ref messageCount); |
Check notice
Code scanning / CodeQL
Static field written by instance method
tamasvajk
commented
Mar 20, 2024
| { | ||
| internal class CompilerDiagnostic : FreshEntity | ||
| { | ||
| private static readonly int limit = EnvironmentVariables.TryGetExtractorOption<int>("COMPILER_DIAGNOSTIC_LIMIT") ?? 1000; |
Contributor
Author
There was a problem hiding this comment.
Should we introduce an extractor option for this? What should be the name for the option?
hvitved
previously approved these changes
Mar 20, 2024
csharp/extractor/Semmle.Extraction.CSharp/Entities/Compilations/CompilerDiagnostic.cs
Show resolved
Hide resolved
tamasvajk
commented
Mar 20, 2024
csharp/extractor/Semmle.Extraction.CSharp/Entities/Compilations/CompilerDiagnostic.cs
Outdated
Show resolved
Hide resolved
tamasvajk
commented
Mar 20, 2024
Contributor
Author
|
@hvitved Can you have a look at the new commits in this PR. |
hvitved
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the number of extraction messages and compiler diagnostics that get stored in the database. I've added some env variables that can fine tune the limits, but I haven't introduced an extractor option for them.