Ruby: add additional sources on the request object of Rails #15604
+68
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some missing sources on the
requestobject of Ruby on Rails (e.g. when used in anActionController). E.g. the possibility of accessing a parameter directly via the request objectrequest["parameter_name"]or accessing a header viarequest.headers['Accept'].There is some overlap with the request properties as modelled for Rack and I am not sure if the original intent was that these sources should be provided by the Rack additions. (Currently they are not however.)
Additionally, I removed the three host related properties
"host_authority", "host", "hostname"inside ofHeadersCallas they were listed twice. (once inHeadersCalland once inHostCall). Maybe there's a reason why they were duplicated...