X Tutup
The Wayback Machine - https://web.archive.org/web/20240215235001/https://github.com/angular/angular/pull/54386
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct default application builder for new apps #54386

Closed
wants to merge 2 commits into from

Conversation

xfh
Copy link
Contributor

@xfh xfh commented Feb 12, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The documentation on angular.dev mentions @angular-devkit/build-angular:browser as default application builder. This is not correct. Recent applications are setup with build-angular:application by default.

What is the new behavior?

The docs name @angular-devkit/build-angular:application as the default application builder.

Does this PR introduce a breaking change?

  • Yes
  • No

The documentation on angular.dev mentions build-angular:browser as default
application builder. This is not correct. Recent applications are setup
with build-angular:application by default.
Copy link

google-cla bot commented Feb 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Feb 12, 2024
@ngbot ngbot bot added this to the Backlog milestone Feb 12, 2024
@xfh xfh requested a review from alan-agius4 February 13, 2024 23:28
Copy link
Contributor

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Feb 14, 2024
@alan-agius4
Copy link
Contributor

caretaker note: my approval should be sufficient for this change.

@AndrewKushnir AndrewKushnir removed the request for review from bencodezen February 15, 2024 18:53
@AndrewKushnir
Copy link
Contributor

This PR was merged into the repository by commit d181a36.

AndrewKushnir pushed a commit that referenced this pull request Feb 15, 2024
The documentation on angular.dev mentions build-angular:browser as default
application builder. This is not correct. Recent applications are setup
with build-angular:application by default.

PR Close #54386
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup