ZipFile: allow setting compress_type/compresslevel in open() as well#102017
Closed
obfusk wants to merge 2 commits intopython:mainfrom
Closed
ZipFile: allow setting compress_type/compresslevel in open() as well#102017obfusk wants to merge 2 commits intopython:mainfrom
obfusk wants to merge 2 commits intopython:mainfrom
Conversation
obfusk
force-pushed
the
zipfile-open-compresslevel
branch
from
7b20705 to
97776b6
Compare
arhadthedev
added
the
stdlib
serhiy-storchaka
added
the
pending
Member
|
You can create a Please open an issue for further discussion. If this change be accepted, the PR will need tests and updating documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, you can set
compress_type/compresslevelwhen writing a ZIP entry withwrite()orwritestr()but not when writing viaopen(); this PR fixes that.