X Tutup
The Wayback Machine - https://web.archive.org/web/20240625001224/https://github.com/python/cpython/issues/113892
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asyncio ProactorEventLoop didn't check if the socket is blocking #113892

Closed
NewUserHa opened this issue Jan 10, 2024 · 2 comments
Closed

asyncio ProactorEventLoop didn't check if the socket is blocking #113892

NewUserHa opened this issue Jan 10, 2024 · 2 comments
Assignees
@Eclips4
Labels
topic-asyncio type-bug An unexpected behavior, bug, or error

Comments

@NewUserHa
Copy link
Contributor

NewUserHa commented Jan 10, 2024 •
edited by bedevere-app bot

Bug report

Bug description:

import asyncio
import socket

s = socket.socket()
await asyncio.get_running_loop().sock_connect(s,('127.0.0.1',80))

according to https://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.sock_connect and

cpython/Lib/asyncio/selector_events.py

Lines 617 to 630 in 5d8a3e7

async def sock_connect(self, sock, address):
"""Connect to a remote socket at address.
This method is a coroutine.
"""
base_events._check_ssl_socket(sock)
if self._debug and sock.gettimeout() != 0:
raise ValueError("the socket must be non-blocking")
if sock.family == socket.AF_INET or (
base_events._HAS_IPv6 and sock.family == socket.AF_INET6):
resolved = await self._ensure_resolved(
address, family=sock.family, type=sock.type, proto=sock.proto,
loop=self,

it should raise. however, ProactorEventLoop doesn't follow the rule

should we fix this, any thoughts

CPython versions tested on:

3.12

Operating systems tested on:

Windows

Linked PRs
@NewUserHa NewUserHa added the type-bug An unexpected behavior, bug, or error label Jan 10, 2024
@gvanrossum
Copy link
Member

Oh, interesting. The question is, does async sending and receiving using that blocked socket work when using the ProactorEventLoop? Given how different IOCP is, it wouldn't surprise me if it did. Can you write a small test to check that? (There are probably tests you can adapt.)

@NewUserHa
Copy link
Contributor Author

ok

@Eclips4 Eclips4 self-assigned this May 24, 2024
Eclips4 added a commit to Eclips4/cpython that referenced this issue May 24, 2024
@Eclips4
pythongh-113892: Add check to ProactorEventLoop.sock_connect to ens…
faf00d8 
…ure that the given socket is in non-blocking mode
@bedevere-app bedevere-app bot mentioned this issue May 24, 2024
Merged
gvanrossum pushed a commit that referenced this issue Jun 1, 2024
@Eclips4
gh-113892: Add a extra check to ProactorEventLoop.sock_connect to e…
cf3bba3 
…nsure that the given socket is in non-blocking mode (#119519)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 1, 2024
@Eclips4 @miss-islington
pythongh-113892: Add a extra check to `ProactorEventLoop.sock_connect…
bea588c 
…` to ensure that the given socket is in non-blocking mode (pythonGH-119519)

(cherry picked from commit cf3bba3)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jun 1, 2024
@Eclips4 @miss-islington
pythongh-113892: Add a extra check to `ProactorEventLoop.sock_connect…
a089b9d 
…` to ensure that the given socket is in non-blocking mode (pythonGH-119519)

(cherry picked from commit cf3bba3)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
This was referenced Jun 1, 2024
Merged
Merged
gvanrossum pushed a commit that referenced this issue Jun 1, 2024
@miss-islington @Eclips4
[3.13] gh-113892: Add a extra check to `ProactorEventLoop.sock_connec…
0ea77d4 
…t` to ensure that the given socket is in non-blocking mode (GH-119519) (#119912)

(cherry picked from commit cf3bba3)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
gvanrossum pushed a commit that referenced this issue Jun 1, 2024
@miss-islington @Eclips4
[3.12] gh-113892: Add a extra check to `ProactorEventLoop.sock_connec…
55f6515 
…t` to ensure that the given socket is in non-blocking mode (GH-119519) (#119913)

(cherry picked from commit cf3bba3)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
barneygale pushed a commit to barneygale/cpython that referenced this issue Jun 5, 2024
@Eclips4 @barneygale
pythongh-113892: Add a extra check to `ProactorEventLoop.sock_connect…
525722c 
…` to ensure that the given socket is in non-blocking mode (python#119519)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Eclips4 Eclips4

Labels
topic-asyncio type-bug An unexpected behavior, bug, or error
Projects
asyncio
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gvanrossum @NewUserHa @Eclips4
X Tutup