X Tutup
The Wayback Machine - https://web.archive.org/web/20240110155304/https://github.com/python/cpython/issues/113845
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New warning: ‘_Py_stdlib_module_names’ defined but not used in Python/stdlib_module_names.h #113845

Open
sobolevn opened this issue Jan 9, 2024 · 6 comments
Open

New warning: ‘_Py_stdlib_module_names’ defined but not used in Python/stdlib_module_names.h #113845

sobolevn opened this issue Jan 9, 2024 · 6 comments
Labels
build The build process and cross-build easy interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@sobolevn
Copy link
Member

sobolevn commented Jan 9, 2024 •
edited by github-actions bot

Bug report

Снимок экрана 2024-01-09 в 11 21 27

This happens in all recent PRs, examples:
@sobolevn sobolevn added type-bug An unexpected behavior, bug, or error interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Jan 9, 2024
@Eclips4
Copy link
Member

Eclips4 commented Jan 9, 2024 •
edited

Seems it's created for this PR: #113769
It's already used in Python/suggestions.c, so..

@serhiy-storchaka
Copy link
Member

It was introduced by #110721. @pablogsal

@serhiy-storchaka serhiy-storchaka added build The build process and cross-build easy labels Jan 9, 2024
@pablogsal
Copy link
Member

As probably will be used in #113769 let's not remove yet.

@serhiy-storchaka
Copy link
Member

serhiy-storchaka commented Jan 9, 2024 •
edited

#113769 does not touch Python/suggestions.c.

@pablogsal
Copy link
Member

#113769 does not touch Python/suggestions.c.

No, but uses _Py_stdlib_module_names no?

@pablogsal
Copy link
Member

Ah, sorry, this is because we are #include "stdlib_module_names.h" // _Py_stdlib_module_names in suggestions.c. Right, I will create a PR removing the include 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build The build process and cross-build easy interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@serhiy-storchaka @sobolevn @pablogsal @Eclips4
X Tutup