X Tutup
The Wayback Machine - https://web.archive.org/web/20240503020551/https://github.com/python/cpython/issues/63283
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IDNA prefix should be case insensitive #63283

Closed
pepijndevos mannequin opened this issue Sep 24, 2013 · 5 comments
Closed

IDNA prefix should be case insensitive #63283

pepijndevos mannequin opened this issue Sep 24, 2013 · 5 comments
Labels
3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@pepijndevos
Copy link
Mannequin

pepijndevos mannequin commented Sep 24, 2013 •
edited by bedevere-app bot

BPO 19083
Nosy @loewis, @ZackerySpytz
PRs
  • gh-63283: IDNA prefix should be case insensitive #17726
    		•
    Files
  • upper-idna.patch
  • upper-idna.patch
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2013-09-24.15:20:51.183>
labels = ['type-bug', 'library', '3.9', '3.10', '3.11']
title = 'IDNA prefix should be case insensitive'
updated_at = <Date 2021-05-22.17:27:48.889>
user = 'https://bugs.python.org/PepijndeVos'

    bugs.python.org fields:

    activity = <Date 2021-05-22.17:27:48.889>
actor = 'iritkatriel'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2013-09-24.15:20:51.183>
creator = 'Pepijn.de.Vos'
dependencies = []
files = ['31858', '31878']
hgrepos = []
issue_num = 19083
keywords = ['patch']
message_count = 4.0
messages = ['198360', '198437', '198438', '198448']
nosy_count = 3.0
nosy_names = ['loewis', 'Pepijn.de.Vos', 'ZackerySpytz']
pr_nums = ['17726']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue19083'
versions = ['Python 3.9', 'Python 3.10', 'Python 3.11']

    Linked PRs
    @pepijndevos
    Copy link
    Mannequin Author

    pepijndevos mannequin commented Sep 24, 2013

    RFC 3490 states that "The ACE prefix for IDNA is "xn--" or any capitalization thereof."

    But the following does not work

    >> str(b"XN--pythn-mua.org.", "idna")

    @pepijndevos pepijndevos mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Sep 24, 2013
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Sep 26, 2013

    Pepijn: Can you please submit the contributor form?

    http://www.python.org/psf/contrib/contrib-form/

    @vstinner
    Copy link
    Member

    Could you also add a test using a IDNA domain not starting with XN--, but with XN-- in the middle? Example:

    self.assertEqual(str(b"bugs.XN--pythn-mua.org.", "idna"), "bugs.pyth\xf6n.org.")

    And maybe also with mixed cases: Xn-- and xN-- prefixes.

    @pepijndevos
    Copy link
    Mannequin Author

    pepijndevos mannequin commented Sep 26, 2013

    Ok, I signed the agreement and included a few more tests.

    @ZackerySpytz ZackerySpytz mannequin added 3.7 (EOL) end of life 3.8 only security fixes 3.9 only security fixes labels Dec 28, 2019
    @iritkatriel iritkatriel added 3.10 only security fixes 3.11 only security fixes and removed 3.7 (EOL) end of life 3.8 only security fixes labels May 22, 2021
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @erlend-aasland erlend-aasland added 3.12 bugs and security fixes 3.13 new features, bugs and security fixes and removed 3.10 only security fixes 3.9 only security fixes labels Jan 5, 2024
    @bedevere-app bedevere-app bot mentioned this issue Jan 5, 2024
    Merged
    encukou added a commit that referenced this issue Mar 15, 2024
    @ZackerySpytz @pepijndevos
    @erlend-aasland @encukou
    gh-63283: IDNA prefix should be case insensitive (GH-17726)
    d180b50 
    Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-authored-by: Pepijn de Vos <pepijndevos@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 15, 2024
    @ZackerySpytz @pepijndevos
    @erlend-aasland @encukou @miss-islington
    pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
    7e992b1 
    Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490GH-section-5).

(cherry picked from commit d180b50)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Pepijn de Vos <pepijndevos@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
    miss-islington pushed a commit to miss-islington/cpython that referenced this issue Mar 15, 2024
    @ZackerySpytz @pepijndevos
    @erlend-aasland @encukou @miss-islington
    pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
    14a63c5 
    Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490GH-section-5).

(cherry picked from commit d180b50)

Co-authored-by: Zackery Spytz <zspytz@gmail.com>
Co-authored-by: Pepijn de Vos <pepijndevos@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
    This was referenced Mar 15, 2024
    Closed
    Closed
    @encukou
    Copy link
    Member

    encukou commented Mar 18, 2024

    I'm not entirely convinced about doing the backports: the bug's been there for a decade, it doesn't look like a very important bug to fix. If it's backported to 3.12.3, programs tested there may break on 3.12.0

    vstinner pushed a commit to vstinner/cpython that referenced this issue Mar 20, 2024
    @ZackerySpytz @pepijndevos
    @erlend-aasland @encukou @vstinner
    pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
    a6dd4a5 
    Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-authored-by: Pepijn de Vos <pepijndevos@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
    @encukou encukou closed this as completed Mar 21, 2024
    adorilson pushed a commit to adorilson/cpython that referenced this issue Mar 25, 2024
    @ZackerySpytz @pepijndevos
    @erlend-aasland @encukou @adorilson
    pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
    272eb90 
    Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-authored-by: Pepijn de Vos <pepijndevos@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
    diegorusso pushed a commit to diegorusso/cpython that referenced this issue Apr 17, 2024
    @ZackerySpytz @pepijndevos
    @erlend-aasland @encukou @diegorusso
    pythongh-63283: IDNA prefix should be case insensitive (pythonGH-17726)
    b5445be 
    Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-authored-by: Pepijn de Vos <pepijndevos@gmail.com>
Co-authored-by: Erlend E. Aasland <erlend@python.org>
Co-authored-by: Petr Viktorin <encukou@gmail.com>
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.11 only security fixes 3.12 bugs and security fixes 3.13 new features, bugs and security fixes stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Milestone
    No milestone
    Development

    No branches or pull requests
    4 participants
    @vstinner @encukou @iritkatriel @erlend-aasland
    X Tutup