X Tutup
The Wayback Machine - https://web.archive.org/web/20240109171002/https://github.com/python/cpython/issues/113696
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PyObject_CallOneArg and PyObject_CallNoArgs should be marked as returning a new reference #113696

Closed
ordinary-jamie opened this issue Jan 4, 2024 · 1 comment
Closed

PyObject_CallOneArg and PyObject_CallNoArgs should be marked as returning a new reference #113696

ordinary-jamie opened this issue Jan 4, 2024 · 1 comment
Labels
docs Documentation in the Doc dir topic-C-API

Comments

@ordinary-jamie
Copy link
Contributor

ordinary-jamie commented Jan 4, 2024 •
edited by bedevere-app bot

Documentation

PyObject_CallOneArg and PyObject_CallNoArgs should be updated in the docs with the reference count annotation "Return value: New reference." (as is the case with PyObject_CallFunction et al.)

Linked PRs
@ordinary-jamie ordinary-jamie added the docs Documentation in the Doc dir label Jan 4, 2024
@bedevere-app bedevere-app bot mentioned this issue Jan 4, 2024
Merged
erlend-aasland pushed a commit that referenced this issue Jan 4, 2024
@ordinary-jamie
gh-113696: Docs: Annotate PyObject_CallOneArg and PyObject_CallNoArgs…
1ae7ceb 
… as returning a strong reference (#113697)
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 4, 2024
@ordinary-jamie @miss-islington
pythongh-113696: Docs: Annotate PyObject_CallOneArg and PyObject_Call…
bdd00c8 
…NoArgs as returning a strong reference (pythonGH-113697)

(cherry picked from commit 1ae7ceb)

Co-authored-by: Jamie Phan <jamie@ordinarylab.dev>
@bedevere-app bedevere-app bot mentioned this issue Jan 4, 2024
Merged
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Jan 4, 2024
@ordinary-jamie @miss-islington
pythongh-113696: Docs: Annotate PyObject_CallOneArg and PyObject_Call…
4426c72 
…NoArgs as returning a strong reference (pythonGH-113697)

(cherry picked from commit 1ae7ceb)

Co-authored-by: Jamie Phan <jamie@ordinarylab.dev>
@bedevere-app bedevere-app bot mentioned this issue Jan 4, 2024
Merged
erlend-aasland pushed a commit that referenced this issue Jan 5, 2024
@miss-islington @ordinary-jamie
[3.12] gh-113696: Docs: Annotate PyObject_CallOneArg and PyObject_Cal…
6f90399 
…lNoArgs as returning a strong reference (GH-113697) (#113698)

(cherry picked from commit 1ae7ceb)

Co-authored-by: Jamie Phan <jamie@ordinarylab.dev>
erlend-aasland pushed a commit that referenced this issue Jan 5, 2024
@miss-islington @ordinary-jamie
[3.11] gh-113696: Docs: Annotate PyObject_CallOneArg and PyObject_Cal…
99b4f1c 
…lNoArgs as returning a strong reference (GH-113697) (#113699)

(cherry picked from commit 1ae7ceb)

Co-authored-by: Jamie Phan <jamie@ordinarylab.dev>
@erlend-aasland
Copy link
Contributor

Thanks, @ordinary-jamie!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Documentation in the Doc dir topic-C-API
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erlend-aasland @Eclips4 @ordinary-jamie
X Tutup