X Tutup
The Wayback Machine - https://web.archive.org/web/20240112013138/https://github.com/python/cpython/issues/113595
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

We shouldn't be entering invalid executors, it rather invalidates the invalidation. #113595

Closed
markshannon opened this issue Dec 31, 2023 · 0 comments
Closed

We shouldn't be entering invalid executors, it rather invalidates the invalidation. #113595

markshannon opened this issue Dec 31, 2023 · 0 comments
Assignees
@markshannon
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@markshannon
Copy link
Member

markshannon commented Dec 31, 2023 •
edited by bedevere-app bot

Bug report

Bug description:

ENTER_EXECUTOR doesn't check if an executor is invalid. We currently get away with this because only instrumentation invalidates executors, and it cleans up the ENTER_EXECUTORs.
It would be safer if ENTER_EXECUTOR check for invalid executors, and it would reduce the coupling between executors and instrumentation.

CPython versions tested on:

CPython main branch

Operating systems tested on:

No response

Linked PRs
@markshannon markshannon added the type-bug An unexpected behavior, bug, or error label Dec 31, 2023
@markshannon markshannon self-assigned this Dec 31, 2023
@bedevere-app bedevere-app bot mentioned this issue Dec 31, 2023
Merged
@Eclips4 Eclips4 added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Dec 31, 2023
markshannon added a commit that referenced this issue Jan 3, 2024
@markshannon
GH-113595: Don't enter invalid executor (GH-113596)
dc8df6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markshannon markshannon

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markshannon @Eclips4
X Tutup