X Tutup
The Wayback Machine - https://web.archive.org/web/20200909031711/https://github.com/nodejs/github-bot/issues/213/
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts/attempt-backport.js `inProgress` is always false #213

Open
Trott opened this issue Feb 21, 2019 · 2 comments
Open

scripts/attempt-backport.js `inProgress` is always false #213

Trott opened this issue Feb 21, 2019 · 2 comments

Comments

@Trott
Copy link
Member

@Trott Trott commented Feb 21, 2019

inProgress is set to false and then never changed. Should it be removed or is there a bug where somewhere it should be set to true but it's not?

@phillipj
Copy link
Member

@phillipj phillipj commented Mar 20, 2019

Very good catch!

Ensuring there's only one backport operation running at once, surely sounds like a good idea to me.

I also notice that script needs some love related to logging, primarily replacing debug with JSON logs via bunyan (read: options.logger) so that we can get a hold of those logs from anywhere / anytime.

@Trott just to confirm; is this functionality still valuable? I haven't been involved in core for a while, but I do remember disabling the dont-land-on-* labels in acd5bc1#diff-eea09a4f0f8288ff9bd49ef44625f0c1. Should we keep it (and improve it) or delete the whole script?

@Trott
Copy link
Member Author

@Trott Trott commented Mar 20, 2019

@Trott just to confirm; is this functionality still valuable? I haven't been involved in core for a while, but I do remember disabling the dont-land-on-* labels in acd5bc1#diff-eea09a4f0f8288ff9bd49ef44625f0c1. Should we keep it (and improve it) or delete the whole script?

I actually have no idea. Is that a question for @nodejs/build or @nodejs/releasers or someone else? /ping @nodejs/github-bot while I'm at it I guess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.
X Tutup