X Tutup
The Wayback Machine - https://web.archive.org/web/20240109142144/https://github.com/python/cpython/issues/113370
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile.pre.in missing some mimalloc dependencies #113370

Closed
colesbury opened this issue Dec 21, 2023 · 0 comments
Closed

Makefile.pre.in missing some mimalloc dependencies #113370

colesbury opened this issue Dec 21, 2023 · 0 comments
Labels
3.13 new features, bugs and security fixes build The build process and cross-build topic-free-threading type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Dec 21, 2023 •
edited by bedevere-app bot

Bug report

The dependencies list for obmalloc.o is missing some files like Objects/mimalloc/prim/unix/prim.c, so modifying those files doesn't rebuild obmalloc.o.

cpython/Makefile.pre.in

Lines 1566 to 1580 in 5f7a80f

Objects/obmalloc.o: $(srcdir)/Objects/mimalloc/alloc.c \
$(srcdir)/Objects/mimalloc/alloc-aligned.c \
$(srcdir)/Objects/mimalloc/alloc-posix.c \
$(srcdir)/Objects/mimalloc/arena.c \
$(srcdir)/Objects/mimalloc/bitmap.c \
$(srcdir)/Objects/mimalloc/heap.c \
$(srcdir)/Objects/mimalloc/init.c \
$(srcdir)/Objects/mimalloc/options.c \
$(srcdir)/Objects/mimalloc/os.c \
$(srcdir)/Objects/mimalloc/page.c \
$(srcdir)/Objects/mimalloc/random.c \
$(srcdir)/Objects/mimalloc/segment.c \
$(srcdir)/Objects/mimalloc/segment-map.c \
$(srcdir)/Objects/mimalloc/stats.c \
$(srcdir)/Objects/mimalloc/prim/prim.c

Linked PRs
@colesbury colesbury added type-bug An unexpected behavior, bug, or error build The build process and cross-build 3.13 new features, bugs and security fixes topic-free-threading labels Dec 21, 2023
colesbury added a commit to colesbury/cpython that referenced this issue Dec 21, 2023
@colesbury
pythongh-113370: Add missing obmalloc.o dependencies on mimalloc
45c3695
@bedevere-app bedevere-app bot mentioned this issue Dec 21, 2023
Merged
erlend-aasland pushed a commit that referenced this issue Dec 21, 2023
@colesbury
gh-113370: Add missing obmalloc.o dependencies on mimalloc (#113371)
31d8757
ryan-duve pushed a commit to ryan-duve/cpython that referenced this issue Dec 26, 2023
@colesbury @ryan-duve
pythongh-113370: Add missing obmalloc.o dependencies on mimalloc (pyt…
0a3c564 
…hon#113371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 new features, bugs and security fixes build The build process and cross-build topic-free-threading type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colesbury @erlend-aasland
X Tutup