X Tutup
The Wayback Machine - https://web.archive.org/web/20231224182338/https://github.com/nodejs/node/pull/51172
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: add server handshake utility #51172

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

http2: add server handshake utility #51172

wants to merge 1 commit into from

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Dec 16, 2023

Adds a new performServerHandshake function which allows an http2 server session to be created from an existing socket. This is admittedly not a common thing that one needs to do, but there are some systems out there where it is needed.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Dec 16, 2023
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs tests and likely a client counterpart.

@jasnell can you check it? I think you were opposed

@devsnek
Copy link
Member Author

devsnek commented Dec 18, 2023

This needs tests and likely a client counterpart.

Yep still a draft, I will write tests. wrt client counterpart, I think http2.connect({ createConnection: () => existingSocket }) fulfills that?

@mcollina
Copy link
Member

Should be!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants
X Tutup